Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1487683005: Remove flaky pixel tests from the SmokeTests suite (Closed)

Created:
5 years ago by Peter Beverloo
Modified:
4 years, 11 months ago
Reviewers:
Dirk Pranke, whywhat
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove flaky pixel tests from the SmokeTests suite These tests have been rebased multiple times now, only to start failing again a (few) days later. The other tests, including pixel tests, are much more stable. Let's remove these tests to reduce the burden on sheriffs. BUG=563448 Committed: https://crrev.com/b67ca118699df23927e3a5d66ee26b1f8964fe8c Cr-Commit-Position: refs/heads/master@{#370702}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M third_party/WebKit/LayoutTests/SmokeTests View 1 4 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Peter Beverloo
+dpranke I'm sure there is a root cause to find for these, but I'm not ...
5 years ago (2015-12-01 17:27:24 UTC) #3
Dirk Pranke
works for me, though these are very old tests, so I'm surprised they're flaky. lgtm.
5 years ago (2015-12-01 18:35:24 UTC) #4
Peter Beverloo
Seems like it was some sort of coincidence that these failed back and forth multiple ...
5 years ago (2015-12-21 15:14:59 UTC) #5
Peter Beverloo
I just re-opened this and will land the CL. avayvod@ noticed that they're flaky again.
4 years, 11 months ago (2016-01-21 15:05:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1487683005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1487683005/20001
4 years, 11 months ago (2016-01-21 15:06:03 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-21 15:47:53 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 15:49:02 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b67ca118699df23927e3a5d66ee26b1f8964fe8c
Cr-Commit-Position: refs/heads/master@{#370702}

Powered by Google App Engine
This is Rietveld 408576698