[cleanup] Remove redundant fields from DeclarationDescriptor

[cleanup] Remove redundant fields from DeclarationDescriptor

Both the is_const and declaration_scope fields can be reliably derived
from the mode field. needs_init cannot be, unfortunately, due to the
special case of CONST in for loops.

Also inline the sole remaining non-trivial caller of
Parser::DeclarationScope(VariableMode).

Committed: https://crrev.com/bc7d63ccef37bb6511e9bc0075518b982b94ab05
Cr-Commit-Position: refs/heads/master@{#32536}

[adamk, 2015-12-01 00:32:00]

adamk@chromium.org changed reviewers:
+ rossberg@chromium.org

[adamk, 2015-12-02 22:25:12]

adamk@chromium.org changed reviewers:
+ littledan@chromium.org

[adamk, 2015-12-02 22:25:12]

adamk@chromium.org changed reviewers:
+ littledan@chromium.org

[adamk, 2015-12-02 22:25:12]

+littledan

[adamk, 2015-12-02 22:25:12]

+littledan

[Dan Ehrenberg, 2015-12-02 22:37:42]

lgtm

[adamk, 2015-12-02 22:39:13]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2015-12-02 22:39:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1487603003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1487603003/1

[commit-bot: I haz the power, 2015-12-02 23:57:34]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-02 23:58:36]

Description was changed from

==========
[cleanup] Remove redundant fields from DeclarationDescriptor

Both the is_const and declaration_scope fields can be reliably derived
from the mode field. needs_init cannot be, unfortunately, due to the
special case of CONST in for loops.

Also inline the sole remaining non-trivial caller of
Parser::DeclarationScope(VariableMode).
==========

to

==========
[cleanup] Remove redundant fields from DeclarationDescriptor

Both the is_const and declaration_scope fields can be reliably derived
from the mode field. needs_init cannot be, unfortunately, due to the
special case of CONST in for loops.

Also inline the sole remaining non-trivial caller of
Parser::DeclarationScope(VariableMode).

Committed: https://crrev.com/bc7d63ccef37bb6511e9bc0075518b982b94ab05
Cr-Commit-Position: refs/heads/master@{#32536}
==========

[commit-bot: I haz the power, 2015-12-02 23:58:37]

Patchset 1 (id:??) landed as
https://crrev.com/bc7d63ccef37bb6511e9bc0075518b982b94ab05
Cr-Commit-Position: refs/heads/master@{#32536}