Chromium Code Reviews

Issue 1487603002: Oilpan: improve adopt{Ref,Ptr}WillBeNoop(T*) static asserts. (Closed)

Created:
5 years ago by sof
Modified:
5 years ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, kouhei+heap_chromium.org, oilpan-reviews, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: improve adopt{Ref,Ptr}WillBeNoop(T*) static asserts. R=haraken BUG=420515 Committed: https://crrev.com/607b3e0f4f9898976684ef2373602064d6e7b8e5 Cr-Commit-Position: refs/heads/master@{#362138}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+5 lines, -4 lines)
M third_party/WebKit/Source/platform/heap/Handle.h View 1 chunk +5 lines, -4 lines 0 comments

Messages

Total messages: 11 (6 generated)
sof
please take a look.
5 years ago (2015-11-30 13:42:41 UTC) #2
haraken
LGTM
5 years ago (2015-11-30 13:43:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1487603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1487603002/1
5 years ago (2015-11-30 14:29:54 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-30 16:11:46 UTC) #9
commit-bot: I haz the power
5 years ago (2015-11-30 16:12:49 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/607b3e0f4f9898976684ef2373602064d6e7b8e5
Cr-Commit-Position: refs/heads/master@{#362138}

Powered by Google App Engine