Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 14876030: Get rid of OS(AIX) (Closed)

Created:
7 years, 7 months ago by kbalazs_
Modified:
7 years, 7 months ago
CC:
blink-reviews, loislo+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, abarth-chromium, adamk+blink_chromium.org, jeez
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Get rid of OS(AIX) Remove the OS(AIX) macro. This is only used in one source file and it is not an officially supported platform. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150427

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M Source/wtf/NumberOfCores.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/wtf/Platform.h View 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Julien - ping for review
I don't understand this change (maybe it's me being thick though). AIX seems to be ...
7 years, 7 months ago (2013-05-14 21:15:37 UTC) #1
abarth-chromium
If we're going to port to AIX, it's likely going to require more than these ...
7 years, 7 months ago (2013-05-14 21:17:03 UTC) #2
kbalazs_
On 2013/05/14 21:17:03, abarth wrote: > If we're going to port to AIX, it's likely ...
7 years, 7 months ago (2013-05-15 09:42:18 UTC) #3
eseidel
lgtm
7 years, 7 months ago (2013-05-15 09:44:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/b.kelemen@sisa.samsung.com/14876030/1
7 years, 7 months ago (2013-05-15 09:45:04 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-05-15 14:20:43 UTC) #6
Message was sent while issue was closed.
Change committed as 150427

Powered by Google App Engine
This is Rietveld 408576698