Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 14876022: Threaded HTML parser ASSERTs on Android (Closed)

Created:
7 years, 7 months ago by abarth-chromium
Modified:
7 years, 7 months ago
Reviewers:
eseidel
CC:
blink-reviews, eae+blinkwatch
Visibility:
Public.

Description

Threaded HTML parser ASSERTs on Android The parser is supposed to stop processing data when there's a pending location change, but before this CL we would actually process the first token from every chunk when there was a pending location change. If the first token in a chunk was a "script" start tag, that would put the tree builder into TextMode, which can only process character tokens. If the next chunk starts with another start tag token, the tree builder would be sad and hit an ASSERT. This CL reorders a couple lines in HTMLDocumentParser so that we check for pending location changes before processing any tokens. This change stops us from processing the first token from each chunk while there is a pending location change. This issue can reproduce on any platform, but it reproduced often on Android because mobile markup often elides spaces between consecutive script tags. If there are space characters between the script tags, then those space characters will be the first ones processes in the chunk, which doesn't trigger the ASSERT. BUG=230542 R=eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150065

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -10 lines) Patch
A LayoutTests/http/tests/navigation/pending-location-change-assert.html View 1 chunk +13 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/navigation/pending-location-change-assert-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
A + LayoutTests/http/tests/resources/slow-notify-done.php View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/core/html/parser/HTMLDocumentParser.cpp View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
abarth-chromium
7 years, 7 months ago (2013-05-09 23:06:04 UTC) #1
eseidel
lgtm Thanks.
7 years, 7 months ago (2013-05-09 23:26:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/14876022/1
7 years, 7 months ago (2013-05-09 23:27:05 UTC) #3
abarth-chromium
7 years, 7 months ago (2013-05-10 00:36:56 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r150065 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698