chrome/browser/chromeos/system/syslogs_provider.cc - Issue 14876021: Re-factor network_event_log

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/system/syslogs_provider.cc

Issue 14876021: Re-factor network_event_log (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address final nits Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/system/syslogs_provider.cc

diff --git a/chrome/browser/chromeos/system/syslogs_provider.cc b/chrome/browser/chromeos/system/syslogs_provider.cc

index 7648a6885602df5dcb8319a6a2c4420951b7093e..45b7074a2767a399c84ab3af44f77850a8f7aaa0 100644

--- a/chrome/browser/chromeos/system/syslogs_provider.cc

+++ b/chrome/browser/chromeos/system/syslogs_provider.cc

@@ -330,9 +330,11 @@ void SyslogsProviderImpl::ReadSyslogs(

dbus::statistics::FORMAT_ALL);

// Include recent network log events

- (*logs)["network_event_log"] = chromeos::network_event_log::GetAsString(

- chromeos::network_event_log::OLDEST_FIRST,

- chromeos::system::kFeedbackMaxLineCount);

+ (*logs)["network_event_log"] = network_event_log::GetAsString(

+ network_event_log::OLDEST_FIRST,

+ "time,file,desc",

+ network_event_log::kDefaultLogLevel,

+ system::kFeedbackMaxLineCount);

// SyslogsMemoryHandler will clean itself up.

// SyslogsMemoryHandler::OnDetailsAvailable() will modify |logs| and call