Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Unified Diff: chromeos/network/network_state_handler_unittest.cc

Issue 14876021: Re-factor network_event_log (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/network_state_handler_unittest.cc
diff --git a/chromeos/network/network_state_handler_unittest.cc b/chromeos/network/network_state_handler_unittest.cc
index 23f9207d0b1fdd9f4ca51362a3f2a73d76b0bdd2..c04140f2fdad35dd9b99555147f2640673de9472 100644
--- a/chromeos/network/network_state_handler_unittest.cc
+++ b/chromeos/network/network_state_handler_unittest.cc
@@ -274,6 +274,14 @@ TEST_F(NetworkStateHandlerTest, ServicePropertyChanged) {
EXPECT_EQ("TestSecurity",
network_state_handler_->GetNetworkState(eth0)->security());
EXPECT_EQ(2, test_observer_->PropertyUpdatesForService(eth0));
+
+ // Changing a service to the exsiting value should not trigger an update.
gauravsh 2013/05/14 00:01:39 existing
stevenjb 2013/05/14 00:27:42 Done.
+ DBusThreadManager::Get()->GetShillServiceClient()->SetProperty(
+ dbus::ObjectPath(eth0),
+ flimflam::kSecurityProperty, security_value,
+ base::Bind(&base::DoNothing), base::Bind(&ErrorCallbackFunction));
+ message_loop_.RunUntilIdle();
+ EXPECT_EQ(2, test_observer_->PropertyUpdatesForService(eth0));
}
TEST_F(NetworkStateHandlerTest, NetworkConnectionStateChanged) {

Powered by Google App Engine
This is Rietveld 408576698