Add wrapper library for the nacl_irt_exception_handling IRT interface

Add wrapper library for the nacl_irt_exception_handling IRT interface

Switch src/untrusted/minidump_generator and src/untrusted/crash_dump
over to using the new wrapper library.

Add the wrapper library to the Gyp build.

Minor cleanup to use perror() to report errno status in
minidump_generator.cc.

BUG=https://code.google.com/p/nativeclient/issues/detail?id=2401
TEST=run_minidump_test_irt run_untrusted_crash_dump_test_irt

Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=11345

[Mark Seaborn, 2013-05-10 16:50:46]

Questions:

 * nacl_code_sdk.gyp doesn't seem to install libraries for ARM or PNaCl.  Does
it actually work?
 * Can we declare dependencies between libraries in the untrusted Gyp build?
 * Are AddLibraryToSdk() and AddHeaderToSdk() in the Scons build relevant any
more?
 * Should I remove the NaClExceptionHandler typedef from irt.h?  It's in the
wrong place for a wrapper library's typedef.  It also doesn't fit the nacl_*
naming scheme that we've partially used for untrusted code.

[bradn, 2013-05-10 17:34:46]

* nacl_code_sdk.gyp doesn't seem to install libraries for ARM or PNaCl.  Does
it actually work?
----
Not sure, I gather some of this is in a transitional state, adding ben and noel.

 * Can we declare dependencies between libraries in the untrusted Gyp build?
----
Sort-of. Yes in the sense that a normal gyp dependency will order them. No in
the sense that a link dependency will not automatically be added.

 * Are AddLibraryToSdk() and AddHeaderToSdk() in the Scons build relevant any
more?
------
Mostly not. AddHeaderToSdk is used for the non-arm toolchain builds to install a
few things for pregcc. AddLibraryToSdk (install_lib) appears to only be used by
the pnacl parts of the sdk, both in tools/Makefile and in the chrome sdk script.

 * Should I remove the NaClExceptionHandler typedef from irt.h?  It's in the
wrong place for a wrapper library's typedef.  It also doesn't fit the nacl_*
naming scheme that we've partially used for untrusted code.
-------
Are you suggesting inlining the definition or having irt.h include something
else?

[binji, 2013-05-10 17:41:26]

On 2013/05/10 17:34:46, bradn wrote:
> * nacl_code_sdk.gyp doesn't seem to install libraries for ARM or PNaCl.  Does
> it actually work?
> ----
It does, but looking at the code in build_sdk.py, we only use it to build
sel_ldr, ncval and nacl_helper_bootstrap.

[Mark Seaborn, 2013-05-14 18:05:34]

Please take a look.

> * nacl_code_sdk.gyp doesn't seem to install libraries for ARM or
> PNaCl.  Does it actually work?
> ----
> Not sure, I gather some of this is in a transitional state, adding ben and
noel.

It turns out it's not actually used.  I've removed my cargo-culted changes to
it.

> * Can we declare dependencies between libraries in the untrusted Gyp
> build?
> ----
> Sort-of. Yes in the sense that a normal gyp dependency will order
> them. No in the sense that a link dependency will not automatically
> be added.

OK, so I've not tried to declare any untrusted library dependencies in Gyp then.

>  * Are AddLibraryToSdk() and AddHeaderToSdk() in the Scons build
> relevant any more?
> ------
> Mostly not. AddHeaderToSdk is used for the non-arm toolchain builds
> to install a few things for pregcc. AddLibraryToSdk (install_lib)
> appears to only be used by the pnacl parts of the sdk, both in
> tools/Makefile and in the chrome sdk script.

I tested and found that AddLibraryToSdk() affects what's installed by
"./pnacl/build.sh sdk", but AddHeaderToSdk() doesn't.  I've left this as is and
avoided cargo-culting.

>  * Should I remove the NaClExceptionHandler typedef from irt.h?
> It's in the wrong place for a wrapper library's typedef.  It also
> doesn't fit the nacl_* naming scheme that we've partially used for
> untrusted code.
> -------
> Are you suggesting inlining the definition or having irt.h include
> something else?

OK, I've cleaned up some use of typedefs, but I've left alone
NaClExceptionHandler in irt.h since irt.h probably can't reliably #include
<nacl/nacl_exception.h> yet, and it wouldn't be good for it to #include
"native_client/src/include/nacl/nacl_exception.h".

[bradn, 2013-05-14 18:22:34]

lgtm

[Mark Seaborn, 2013-05-14 18:29:53]

Committed patchset #4 manually as r11345 (presubmit successful).