Source/web/SourceBufferPrivateImpl.h - Issue 14876007: Add Blink side support for SourceBuffer.appendWindowStart & SourceBuffer.appendWindowEnd.

Side by Side Diff: Source/web/SourceBufferPrivateImpl.h

Issue 14876007: Add Blink side support for SourceBuffer.appendWindowStart & SourceBuffer.appendWindowEnd. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « Source/modules/mediasource/SourceBuffer.idl ('k') | Source/web/SourceBufferPrivateImpl.cpp » ('j') | public/web/WebSourceBuffer.h » ('J')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2013 Google Inc. All rights reserved.	2 * Copyright (C) 2013 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 21 matching lines...) Expand all Loading...
32 #define SourceBufferPrivateImpl_h	32 #define SourceBufferPrivateImpl_h

33	33

34 #include "core/platform/graphics/SourceBufferPrivate.h"	34 #include "core/platform/graphics/SourceBufferPrivate.h"

35 #include "wtf/OwnPtr.h"	35 #include "wtf/OwnPtr.h"

36 #include "wtf/PassOwnPtr.h"	36 #include "wtf/PassOwnPtr.h"

37	37

38 namespace WebKit {	38 namespace WebKit {

39	39

40 class WebSourceBuffer;	40 class WebSourceBuffer;

41	41

42 class SourceBufferPrivateImpl : public WebCore::SourceBufferPrivate {	42 class SourceBufferPrivateImpl : public WebCore::SourceBufferPrivate {
	jamesr 2013/08/09 01:00:36 why does this class exist? WebKit::WebSourceBuffe why does this class exist? WebKit::WebSourceBuffer looks like a very simple interface type that could live in public/platform/, in which case WebCore::SourceBuffer could be implemented directly on top of it. Or maybe the WebCore sourcebuffer type doesn't need to exist at all, depending on what uses it. This extra indirection seems unnecessary
43 public:	43 public:

44 explicit SourceBufferPrivateImpl(PassOwnPtr<WebSourceBuffer>);	44 explicit SourceBufferPrivateImpl(PassOwnPtr<WebSourceBuffer>);

45 virtual ~SourceBufferPrivateImpl() { }	45 virtual ~SourceBufferPrivateImpl() { }

46	46

47 // SourceBufferPrivate methods.	47 // SourceBufferPrivate methods.

48 virtual PassRefPtr<WebCore::TimeRanges> buffered() OVERRIDE;	48 virtual PassRefPtr<WebCore::TimeRanges> buffered() OVERRIDE;

49 virtual void append(const unsigned char* data, unsigned length) OVERRIDE;	49 virtual void append(const unsigned char* data, unsigned length) OVERRIDE;

50 virtual void abort() OVERRIDE;	50 virtual void abort() OVERRIDE;

51 virtual void remove(double start, double end) OVERRIDE;	51 virtual void remove(double start, double end) OVERRIDE;

52 virtual bool setTimestampOffset(double) OVERRIDE;	52 virtual bool setTimestampOffset(double) OVERRIDE;

	53 virtual void setAppendWindowStart(double) OVERRIDE;

	54 virtual void setAppendWindowEnd(double) OVERRIDE;

53 virtual void removedFromMediaSource() OVERRIDE;	55 virtual void removedFromMediaSource() OVERRIDE;

54	56

55 private:	57 private:

56 OwnPtr<WebSourceBuffer> m_sourceBuffer;	58 OwnPtr<WebSourceBuffer> m_sourceBuffer;

57 };	59 };

58	60

59	61

60 }	62 }

61	63

62 #endif	64 #endif

OLD	NEW