Add Blink side support for SourceBuffer.appendWindowStart & SourceBuffer.appendWindowEnd.

Source/modules/mediasource/SourceBuffer.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 23 matching lines @@
 #include "bindings/v8/ExceptionState.h"
 #include "core/dom/Event.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/dom/GenericEventQueue.h"
 #include "core/html/TimeRanges.h"
 #include "core/platform/Logging.h"
 #include "core/platform/graphics/SourceBufferPrivate.h"
 #include "modules/mediasource/MediaSource.h"
 #include "wtf/ArrayBuffer.h"
 #include "wtf/ArrayBufferView.h"
+#include "wtf/MathExtras.h"
+
+#include <limits>
 
 namespace WebCore {
 
 PassRefPtr<SourceBuffer> SourceBuffer::create(PassOwnPtr<SourceBufferPrivate> sourceBufferPrivate, MediaSource* source, GenericEventQueue* asyncEventQueue)
 {
     RefPtr<SourceBuffer> sourceBuffer(adoptRef(new SourceBuffer(sourceBufferPrivate, source, asyncEventQueue)));
     sourceBuffer->suspendIfNeeded();
     return sourceBuffer.release();
 }
 
 SourceBuffer::SourceBuffer(PassOwnPtr<SourceBufferPrivate> sourceBufferPrivate, MediaSource* source, GenericEventQueue* asyncEventQueue)
     : ActiveDOMObject(source->scriptExecutionContext())
     , m_private(sourceBufferPrivate)
     , m_source(source)
     , m_asyncEventQueue(asyncEventQueue)
     , m_updating(false)
     , m_timestampOffset(0)
     , m_appendBufferTimer(this, &SourceBuffer::appendBufferTimerFired)
+    , m_appendWindowStart(0)
+    , m_appendWindowEnd(std::numeric_limits<double>::infinity())
 {
     ASSERT(m_private);
     ASSERT(m_source);
     ScriptWrappable::init(this);
 }
 
 SourceBuffer::~SourceBuffer()
 {
     ASSERT(isRemoved());
 }
@@ skipping 36 matching lines @@
     // and abort these steps.
     if (!m_private->setTimestampOffset(offset)) {
         es.throwDOMException(InvalidStateError);
         return;
     }
 
     // 6. Update the attribute to the new value.
     m_timestampOffset = offset;
 }
 
+double SourceBuffer::appendWindowStart() const
+{
+    return m_appendWindowStart;
+}
+
+void SourceBuffer::setAppendWindowStart(double start, ExceptionState& es)
+{
+    // Section 3.1 appendWindowStart attribute setter steps.

[acolwell GONE FROM CHROMIUM, 2013/08/06 18:10:33]

You should probably add code along these lines to enforce the 'restricted
double' rules.

// Enforce throwing an exception on restricted double values.
if (std::isnan(start) ||
  start == std::numeric_limits<double>::infinity() ||
  start == -std::numeric_limits<double>::infinity()) {
  es.throwDOMException(TypeMismatchError);
  return;
}

+    // 1. If this object has been removed from the sourceBuffers attribute of the parent media source then throw an
+    //    InvalidStateError exception and abort these steps.
+    if (isRemoved()) {
+        es.throwDOMException(InvalidStateError);
+        return;
+    }
+
+    // 2. If the updating attribute equals true, then throw an INVALID_STATE_ERR exception and abort these steps.

[acolwell GONE FROM CHROMIUM, 2013/08/06 18:10:33]

nit: s/INVALID_STATE_ERR/InvalidStateError

+    if (m_updating) {

[acolwell GONE FROM CHROMIUM, 2013/08/06 18:10:33]

nit: This could be added to the conditional above.

+        es.throwDOMException(InvalidStateError);
+        return;
+    }
+
+    // 3. If the new value is less than 0 or greater than or equal to appendWindowEnd then throw an InvalidAccessError
+    //    exception and abort these steps.
+    if (start < 0 || start >= m_appendWindowEnd) {
+        es.throwDOMException(InvalidAccessError);
+        return;
+    }
+
+    m_private->setAppendWindowStart(start);
+
+    // 4. Update the attribute to the new value.
+    m_appendWindowStart = start;
+}
+
+double SourceBuffer::appendWindowEnd() const
+{
+    return m_appendWindowEnd;
+}
+
+void SourceBuffer::setAppendWindowEnd(double end, ExceptionState& es)
+{
+    // Section 3.1 appendWindowEnd attribute setter steps.
+    // 1. If this object has been removed from the sourceBuffers attribute of the parent media source then throw an
+    //    InvalidStateError exception and abort these steps.
+    if (isRemoved()) {
+        es.throwDOMException(InvalidStateError);
+        return;
+    }
+
+    // 2. If the updating attribute equals true, then throw an INVALID_STATE_ERR exception and abort these steps.

[acolwell GONE FROM CHROMIUM, 2013/08/06 18:10:33]

nit: s/INVALID_STATE_ERR/InvalidStateError

+    if (m_updating) {

[acolwell GONE FROM CHROMIUM, 2013/08/06 18:10:33]

nit: this could be added to the conditional above.

+        es.throwDOMException(InvalidStateError);
+        return;
+    }
+
+    // 3. If the new value equals NaN, then throw an INVALID_ACCESS_ERR and abort these steps.

[acolwell GONE FROM CHROMIUM, 2013/08/06 18:10:33]

nit: s/INVALID_ACCESS_ERR/InvalidAccessError

+    if (std::isnan(end)) {
+        es.throwDOMException(InvalidAccessError);
+        return;
+    }
+
+    // 4. If the new value is less than or equal to appendWindowStart then throw an InvalidAccessError
+    //    exception and abort these steps.
+    if (end <= m_appendWindowStart) {

[acolwell GONE FROM CHROMIUM, 2013/08/06 18:10:33]

nit: This can be added to the conditional above.

+        es.throwDOMException(InvalidAccessError);
+        return;
+    }
+
+    m_private->setAppendWindowEnd(end);
+
+    // 5. Update the attribute to the new value.
+    m_appendWindowEnd = end;
+}
+
+
+
 void SourceBuffer::appendBuffer(PassRefPtr<ArrayBuffer> data, ExceptionState& es)
 {
     // Section 3.2 appendBuffer()
     // https://dvcs.w3.org/hg/html-media/raw-file/default/media-source/media-source.html#widl-SourceBuffer-appendBuffer-void-ArrayBufferView-data
     // 1. If data is null then throw an InvalidAccessError exception and abort these steps.
     if (!data) {
         es.throwDOMException(InvalidAccessError);
         return;
     }
 
@@ skipping 25 matching lines @@
         es.throwDOMException(InvalidStateError);
         return;
     }
 
     // 3. If the sourceBuffer.updating attribute equals true, then run the following steps: ...
     abortIfUpdating();
 
     // 4. Run the reset parser state algorithm.
     m_private->abort();
 
-    // FIXME(229408) Add steps 5-6 update appendWindowStart & appendWindowEnd.
+    // 5. Set appendWindowStart to 0.
+    m_appendWindowStart = 0;

[acolwell GONE FROM CHROMIUM, 2013/08/06 18:10:33]

nit: This doesn't notify m_private about this change. Change this to
setAppendWindowStart(0, es) just so all changes to this variable go through the
same codepath.

+
+    // 6. Set appendWindowEnd to positive Infinity.
+    m_appendWindowEnd = std::numeric_limits<double>::infinity();

[acolwell GONE FROM CHROMIUM, 2013/08/06 18:10:33]

nit: ditto. Call setAppendWindowEnd(std::numeric_limits<double>::infinity(), es)
instead.

 }
 
 
 void SourceBuffer::abortIfUpdating()
 {
     // Section 3.2 abort() method step 3 substeps.
     // https://dvcs.w3.org/hg/html-media/raw-file/default/media-source/media-source.html#widl-SourceBuffer-abort-void
 
     if (!m_updating)
         return;
@@ skipping 121 matching lines @@
     m_pendingAppendData.clear();
 
     // 4. Queue a task to fire a simple event named update at this SourceBuffer object.
     scheduleEvent(eventNames().updateEvent);
 
     // 5. Queue a task to fire a simple event named updateend at this SourceBuffer object.
     scheduleEvent(eventNames().updateendEvent);
 }
 
 } // namespace WebCore