Fix an assertion failure in CPDFSDK_Widget* Field::GetWidget()

Fix an assertion failure in CPDFSDK_Widget* Field::GetWidget()

BUG=pdfium:291
R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/14b20dba4e47c6ac3cb119e23bac42e3debb56e4

[jun_fang, 2015-11-30 09:20:55]

jun_fang@foxitsoftware.com changed reviewers:
+ kai_jing@foxitsoftware.com, thestig@chromium.org, tsepez@chromium.org

[jun_fang, 2015-11-30 09:20:56]

Hi Tom and Lei,

Please help to review it. Thanks!

[Tom Sepez, 2015-11-30 17:19:11]

lgtm

https://codereview.chromium.org/1487553003/diff/1/fpdfsdk/src/javascript/Fiel...
File fpdfsdk/src/javascript/Field.cpp (right):

https://codereview.chromium.org/1487553003/diff/1/fpdfsdk/src/javascript/Fiel...
fpdfsdk/src/javascript/Field.cpp:292: ASSERT(pDocument);
Nit: we can remove this assert because pDocument->GetInterForm() will segv if
pDocument is null, so we get the equivalent assertion from the hardware for free
without adding any instructions.

[jun_fang, 2015-12-01 04:30:12]

https://codereview.chromium.org/1487553003/diff/1/fpdfsdk/src/javascript/Fiel...
File fpdfsdk/src/javascript/Field.cpp (right):

https://codereview.chromium.org/1487553003/diff/1/fpdfsdk/src/javascript/Fiel...
fpdfsdk/src/javascript/Field.cpp:292: ASSERT(pDocument);
On 2015/11/30 17:19:11, Tom Sepez wrote:
> Nit: we can remove this assert because pDocument->GetInterForm() will segv if
> pDocument is null, so we get the equivalent assertion from the hardware for
free
> without adding any instructions.

Acknowledged.

[jun_fang, 2015-12-01 04:35:34]

Description was changed from

==========
Fix an assertion failure in CPDFSDK_Widget* Field::GetWidget()

BUG=pdfium:291
==========

to

==========
Fix an assertion failure in CPDFSDK_Widget* Field::GetWidget()

BUG=pdfium:291
R=tsepez@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/14b20dba4e47c6ac3cb119e23bac42e3debb...
==========

[jun_fang, 2015-12-01 04:35:36]

Committed patchset #2 (id:20001) manually as
14b20dba4e47c6ac3cb119e23bac42e3debb56e4 (presubmit successful).