Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1732)

Unified Diff: ui/message_center/cocoa/notification_controller.mm

Issue 1487373003: Reposition the settings button as part of the notification update method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/message_center/cocoa/notification_controller.mm
diff --git a/ui/message_center/cocoa/notification_controller.mm b/ui/message_center/cocoa/notification_controller.mm
index e10cf3716eef43bdb506e8ab732f49496b0bfc97..c7d25c892bc70e5301fc3cb323777667cbd6fb8d 100644
--- a/ui/message_center/cocoa/notification_controller.mm
+++ b/ui/message_center/cocoa/notification_controller.mm
@@ -457,6 +457,7 @@
maxNumberOfLines:message_center::kContextMessageLineLimit];
[contextMessage_ setString:base::SysUTF16ToNSString(elided)];
[contextMessage_ sizeToFit];
+
NSRect contextMessageFrame = [contextMessage_ frame];
if (notification->context_message().empty() &&
@@ -472,6 +473,7 @@
NSHeight(contextMessageFrame);
contextMessageFrame.size.height = NSHeight([contextMessage_ frame]);
}
+ NSRect settingsButtonFrame = [settingsButton_ frame];
// Create the list item views (up to a maximum).
[listView_ removeFromSuperview];
@@ -661,6 +663,7 @@
[title_ setFrame:titleFrame];
[message_ setFrame:messageFrame];
[contextMessage_ setFrame:contextMessageFrame];
+ [settingsButton_ setFrame:settingsButtonFrame];
[listView_ setFrame:listFrame];
[progressBarView_ setFrame:progressBarFrame];
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698