Reposition the settings button as part of the notification update method

ui/message_center/cocoa/notification_controller.mm

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ui/message_center/cocoa/notification_controller.h"
 
 #include <algorithm>
 
 #include "base/mac/foundation_util.h"
 #include "base/strings/string_util.h"
@@ skipping 439 matching lines @@
   } else {
     message = notification->context_message();
   }
 
   base::string16 elided =
       [self wrapText:message
              forFont:[contextMessage_ font]
           maxNumberOfLines:message_center::kContextMessageLineLimit];
   [contextMessage_ setString:base::SysUTF16ToNSString(elided)];
   [contextMessage_ sizeToFit];
+
   NSRect contextMessageFrame = [contextMessage_ frame];
 
   if (notification->context_message().empty() &&
       !notification->UseOriginAsContextMessage()) {
     [contextMessage_ setHidden:YES];
     contextMessageFrame.origin.y = messageFrame.origin.y;
     contextMessageFrame.size.height = 0;
   } else {
     [contextMessage_ setHidden:NO];
     contextMessageFrame.origin.y =
         NSMinY(messageFrame) -
         contextMessagePadding -
         NSHeight(contextMessageFrame);
     contextMessageFrame.size.height = NSHeight([contextMessage_ frame]);
   }
 
+  NSRect settingsButtonFrame;
+  if (settingsButton_ != nil)

[Robert Sesek, 2015/12/02 15:59:38]

You can skip the nil check here and on 669, since in ObjC, messaging to nil
always returns a zero value.

[Miguel Garcia, 2015/12/02 16:37:00]

Wow I am starting to like this ObjC business :)

+    settingsButtonFrame = [settingsButton_ frame];
+
   // Create the list item views (up to a maximum).
   [listView_ removeFromSuperview];
   NSRect listFrame = NSZeroRect;
   if (items.size() > 0) {
     listFrame = [self currentContentRect];
     listFrame.origin.y = 0;
     listFrame.size.height = 0;
     listView_.reset([[NSView alloc] initWithFrame:listFrame]);
     [listView_ accessibilitySetOverrideValue:NSAccessibilityListRole
                                     forAttribute:NSAccessibilityRoleAttribute];
@@ skipping 168 matching lines @@
     messageFrame.origin.y += bottomAdjust;
     contextMessageFrame.origin.y += bottomAdjust;
     listFrame.origin.y += bottomAdjust;
     progressBarFrame.origin.y += bottomAdjust;
   }
 
   [[self view] setFrame:rootFrame];
   [title_ setFrame:titleFrame];
   [message_ setFrame:messageFrame];
   [contextMessage_ setFrame:contextMessageFrame];
+  if (settingsButton_ != nil)
+    [settingsButton_ setFrame:settingsButtonFrame];
   [listView_ setFrame:listFrame];
   [progressBarView_ setFrame:progressBarFrame];
 
   return rootFrame;
 }
 
 - (void)close:(id)sender {
   [closeButton_ setTarget:nil];
   messageCenter_->RemoveNotification([self notificationID], /*by_user=*/true);
 }
@@ skipping 283 matching lines @@
                    forFont:(NSFont*)nsfont
           maxNumberOfLines:(size_t)lines {
   size_t unused;
   return [self wrapText:text
                 forFont:nsfont
        maxNumberOfLines:lines
             actualLines:&unused];
 }
 
 @end