Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: third_party/WebKit/Source/core/fetch/FetchRequest.cpp

Issue 1487343002: Set credentials mode "same-origin" when crossOrigin=anonymous is set. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/FetchRequest.cpp
diff --git a/third_party/WebKit/Source/core/fetch/FetchRequest.cpp b/third_party/WebKit/Source/core/fetch/FetchRequest.cpp
index f620a4d433257e9c42d80fa65ffe8c420ff5e784..3fd353f623fbdcd72a626f71cd79736948a65051 100644
--- a/third_party/WebKit/Source/core/fetch/FetchRequest.cpp
+++ b/third_party/WebKit/Source/core/fetch/FetchRequest.cpp
@@ -72,26 +72,24 @@ FetchRequest::~FetchRequest()
{
}
-void FetchRequest::setCrossOriginAccessControl(SecurityOrigin* origin, StoredCredentials allowCredentials, CredentialRequest requested)
+void FetchRequest::setCrossOriginAccessControl(SecurityOrigin* origin, CrossOriginAttributeValue crossOrigin)
{
- ASSERT(requested == ClientDidNotRequestCredentials || allowCredentials == AllowStoredCredentials);
+ ASSERT(crossOrigin != CrossOriginAttributeNotSet);
+ const bool useCredentials = crossOrigin == CrossOriginAttributeUseCredentials;
+ const bool isSameOriginRequest = origin && origin->canRequestNoSuborigin(m_resourceRequest.url());
+
+ // Currently FetchRequestMode and FetchCredentialsMode are only used when the request goes to Service Worker.
m_resourceRequest.setFetchRequestMode(WebURLRequest::FetchRequestModeCORS);
- updateRequestForAccessControl(m_resourceRequest, origin, allowCredentials);
- m_options.allowCredentials = allowCredentials;
+ m_resourceRequest.setFetchCredentialsMode(useCredentials ? WebURLRequest::FetchCredentialsModeInclude : WebURLRequest::FetchCredentialsModeSameOrigin);
+
+ m_options.allowCredentials = (isSameOriginRequest || useCredentials) ? AllowStoredCredentials : DoNotAllowStoredCredentials;
m_options.corsEnabled = IsCORSEnabled;
m_options.securityOrigin = origin;
- m_options.credentialsRequested = requested;
-}
+ m_options.credentialsRequested = useCredentials ? ClientRequestedCredentials : ClientDidNotRequestCredentials;
-void FetchRequest::setCrossOriginAccessControl(SecurityOrigin* origin, StoredCredentials allowCredentials)
-{
- setCrossOriginAccessControl(origin, allowCredentials, allowCredentials == AllowStoredCredentials ? ClientRequestedCredentials : ClientDidNotRequestCredentials);
+ updateRequestForAccessControl(m_resourceRequest, origin, m_options.allowCredentials);
}
-void FetchRequest::setCrossOriginAccessControl(SecurityOrigin* origin, const AtomicString& crossOriginMode)
-{
- setCrossOriginAccessControl(origin, equalIgnoringCase(crossOriginMode, "use-credentials") ? AllowStoredCredentials : DoNotAllowStoredCredentials);
-}
void FetchRequest::setResourceWidth(ResourceWidth resourceWidth)
{
« no previous file with comments | « third_party/WebKit/Source/core/fetch/FetchRequest.h ('k') | third_party/WebKit/Source/core/html/HTMLLinkElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698