third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp - Issue 1487343002: Set credentials mode "same-origin" when crossOrigin=anonymous is set.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp

Issue 1487343002: Set credentials mode "same-origin" when crossOrigin=anonymous is set. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: set credentials mode in DocumentThreadableLoader::makeCrossOriginAccessRequest() Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/security/img-crossorigin-cookies.html ('K') | « third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp ('k') | third_party/WebKit/Source/core/html/parser/HTMLResourcePreloaderTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp

diff --git a/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp b/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp

index bff78e5ee0e75b3a375709a07ead6407db57a152..9e333e21181af9199d3bfe22b43d700f9974f642 100644

--- a/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp

+++ b/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp

@@ -56,14 +56,7 @@ static void preconnectHost(PreloadRequest* request, const NetworkHintsInterface&

KURL host(request->baseURL(), request->resourceURL());

if (!host.isValid() || !host.protocolIsInHTTPFamily())

return;

- CrossOriginAttributeValue crossOrigin = CrossOriginAttributeNotSet;

- if (request->isCORS()) {

- if (request->isAllowCredentials())

- crossOrigin = CrossOriginAttributeUseCredentials;

- else

- crossOrigin = CrossOriginAttributeAnonymous;

- }

- networkHintsInterface.preconnectHost(host, crossOrigin);

+ networkHintsInterface.preconnectHost(host, request->crossOrigin());

}

void HTMLResourcePreloader::preload(PassOwnPtr<PreloadRequest> preload, const NetworkHintsInterface& networkHintsInterface)