third_party/WebKit/Source/core/fetch/CrossOriginAccessControl.cpp - Issue 1487343002: Set credentials mode "same-origin" when crossOrigin=anonymous is set.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/CrossOriginAccessControl.cpp

Issue 1487343002: Set credentials mode "same-origin" when crossOrigin=anonymous is set. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: set credentials mode in DocumentThreadableLoader::makeCrossOriginAccessRequest() Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/security/img-crossorigin-cookies.html ('K') | « third_party/WebKit/Source/core/dom/ScriptLoader.cpp ('k') | third_party/WebKit/Source/core/fetch/FetchRequest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/CrossOriginAccessControl.cpp

diff --git a/third_party/WebKit/Source/core/fetch/CrossOriginAccessControl.cpp b/third_party/WebKit/Source/core/fetch/CrossOriginAccessControl.cpp

index 770adfbaec7bc43c267620da96679197477ca667..3f7502eb476bc344f56658b771f3e5873a7b0fa4 100644

--- a/third_party/WebKit/Source/core/fetch/CrossOriginAccessControl.cpp

+++ b/third_party/WebKit/Source/core/fetch/CrossOriginAccessControl.cpp

@@ -66,7 +66,6 @@ void updateRequestForAccessControl(ResourceRequest& request, SecurityOrigin* sec

{

request.removeCredentials();

request.setAllowStoredCredentials(allowCredentials == AllowStoredCredentials);

- request.setFetchCredentialsMode(allowCredentials == AllowStoredCredentials ? WebURLRequest::FetchCredentialsModeInclude : WebURLRequest::FetchCredentialsModeOmit);

if (securityOrigin)

request.setHTTPOrigin(securityOrigin);