Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 1487333004: mus: Notify the client whether adding an accelerator was successful. (Closed)

Created:
5 years ago by sadrul
Modified:
5 years ago
CC:
chromium-reviews, rjkroege, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, penghuang+watch-mandoline_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mus: Notify the client whether adding an accelerator was successful. Adding an accelerator can fail if an accelerator with the same id or the same event-matcher already exists. So, notify the client whether adding the accelerator was successful or not. BUG=none Committed: https://crrev.com/3b1906f45a94bb4ec65ddef167b9ea1a7ddefcec Cr-Commit-Position: refs/heads/master@{#362822}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -27 lines) Patch
M components/mus/public/interfaces/window_tree_host.mojom View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M components/mus/ws/event_dispatcher.h View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M components/mus/ws/event_dispatcher.cc View 1 2 3 chunks +5 lines, -7 lines 0 comments Download
M components/mus/ws/event_dispatcher_unittest.cc View 1 2 1 chunk +36 lines, -0 lines 0 comments Download
M components/mus/ws/window_tree_host_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/mus/ws/window_tree_host_impl.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M mandoline/ui/desktop_ui/browser_window.cc View 1 chunk +16 lines, -12 lines 0 comments Download
M mash/wm/window_manager_application.cc View 3 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
sadrul
5 years ago (2015-12-02 19:05:24 UTC) #3
Ben Goodger (Google)
lgtm
5 years ago (2015-12-02 20:06:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1487333004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1487333004/40001
5 years ago (2015-12-02 22:45:42 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-02 23:50:53 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-02 23:52:28 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3b1906f45a94bb4ec65ddef167b9ea1a7ddefcec
Cr-Commit-Position: refs/heads/master@{#362822}

Powered by Google App Engine
This is Rietveld 408576698