Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Side by Side Diff: src/arm/macro-assembler-arm.cc

Issue 148733005: Move failing ASSERT on ARM to a more sane place. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | test/mjsunit/recursive-store-opt.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 491 matching lines...) Expand 10 before | Expand all | Expand 10 after
502 // Will clobber 4 registers: object, address, scratch, ip. The 502 // Will clobber 4 registers: object, address, scratch, ip. The
503 // register 'object' contains a heap object pointer. The heap object 503 // register 'object' contains a heap object pointer. The heap object
504 // tag is shifted away. 504 // tag is shifted away.
505 void MacroAssembler::RecordWrite(Register object, 505 void MacroAssembler::RecordWrite(Register object,
506 Register address, 506 Register address,
507 Register value, 507 Register value,
508 LinkRegisterStatus lr_status, 508 LinkRegisterStatus lr_status,
509 SaveFPRegsMode fp_mode, 509 SaveFPRegsMode fp_mode,
510 RememberedSetAction remembered_set_action, 510 RememberedSetAction remembered_set_action,
511 SmiCheck smi_check) { 511 SmiCheck smi_check) {
512 ASSERT(!object.is(value));
512 if (emit_debug_code()) { 513 if (emit_debug_code()) {
513 ldr(ip, MemOperand(address)); 514 ldr(ip, MemOperand(address));
514 cmp(ip, value); 515 cmp(ip, value);
515 Check(eq, kWrongAddressOrValuePassedToRecordWrite); 516 Check(eq, kWrongAddressOrValuePassedToRecordWrite);
516 } 517 }
517 518
518 // Count number of write barriers in generated code. 519 // Count number of write barriers in generated code.
519 isolate()->counters()->write_barriers_static()->Increment(); 520 isolate()->counters()->write_barriers_static()->Increment();
520 // TODO(mstarzinger): Dynamic counter missing. 521 // TODO(mstarzinger): Dynamic counter missing.
521 522
(...skipping 3552 matching lines...) Expand 10 before | Expand all | Expand 10 after
4074 void CodePatcher::EmitCondition(Condition cond) { 4075 void CodePatcher::EmitCondition(Condition cond) {
4075 Instr instr = Assembler::instr_at(masm_.pc_); 4076 Instr instr = Assembler::instr_at(masm_.pc_);
4076 instr = (instr & ~kCondMask) | cond; 4077 instr = (instr & ~kCondMask) | cond;
4077 masm_.emit(instr); 4078 masm_.emit(instr);
4078 } 4079 }
4079 4080
4080 4081
4081 } } // namespace v8::internal 4082 } } // namespace v8::internal
4082 4083
4083 #endif // V8_TARGET_ARCH_ARM 4084 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | test/mjsunit/recursive-store-opt.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698