Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1487293002: X87: [x86] Sane default for Label::Distance on JumpIfRoot/JumpIfNotRoot. (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [x86] Sane default for Label::Distance on JumpIfRoot/JumpIfNotRoot. port c83db2d071dc3f3493f5d10cf524bd2d8b91ac9b (r32456) original commit message: BUG= Committed: https://crrev.com/a7ec7ebda3404e615632a677628ef706f0889bda Cr-Commit-Position: refs/heads/master@{#32486}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/x87/macro-assembler-x87.h View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
5 years ago (2015-12-02 04:50:43 UTC) #2
Weiliang
lgtm
5 years ago (2015-12-02 05:01:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1487293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1487293002/1
5 years ago (2015-12-02 05:02:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-02 05:20:39 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-02 05:21:23 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a7ec7ebda3404e615632a677628ef706f0889bda
Cr-Commit-Position: refs/heads/master@{#32486}

Powered by Google App Engine
This is Rietveld 408576698