Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3683)

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 1487283005: Implement the new Sync Confirmation dialog on Linux and Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_view.cc
diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc
index 084c4ab16f559c864278c7393352670137d8deaf..d4acbe1781551cd04eb78e7da0dbdb6bc501f7c5 100644
--- a/chrome/browser/ui/views/frame/browser_view.cc
+++ b/chrome/browser/ui/views/frame/browser_view.cc
@@ -2558,7 +2558,6 @@ void BrowserView::ShowAvatarBubbleFromAvatarButton(
profiles::TutorialMode tutorial_mode;
profiles::BubbleViewModeFromAvatarBubbleMode(mode, &bubble_view_mode,
&tutorial_mode);
-
if (SigninViewController::ShouldShowModalSigninForMode(bubble_view_mode)) {
ShowModalSigninWindow(mode, access_point);
} else {
@@ -2573,6 +2572,10 @@ void BrowserView::ShowAvatarBubbleFromAvatarButton(
#endif
}
+void BrowserView::CloseModalSigninWindow() {
+ signin_view_controller_.CloseModalSignin();
+}
+
void BrowserView::ShowModalSigninWindow(
AvatarBubbleMode mode,
signin_metrics::AccessPoint access_point) {
@@ -2584,8 +2587,8 @@ void BrowserView::ShowModalSigninWindow(
access_point);
}
-void BrowserView::CloseModalSigninWindow() {
- signin_view_controller_.CloseModalSignin();
+void BrowserView::ShowModalSyncConfirmationWindow() {
+ signin_view_controller_.ShowModalSyncConfirmationDialog(browser());
}
int BrowserView::GetRenderViewHeightInsetWithDetachedBookmarkBar() {

Powered by Google App Engine
This is Rietveld 408576698