chrome/browser/ui/sync/one_click_signin_sync_starter.h - Issue 1487283005: Implement the new Sync Confirmation dialog on Linux and Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/sync/one_click_signin_sync_starter.h

Issue 1487283005: Implement the new Sync Confirmation dialog on Linux and Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reverted a few sign changes missed in last patchset Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/sync_confirmation/sync_confirmation.js ('K') | « chrome/browser/ui/cocoa/browser_window_cocoa.mm ('k') | chrome/browser/ui/sync/one_click_signin_sync_starter.cc » ('j') | chrome/browser/ui/webui/signin/sync_confirmation_handler.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/sync/one_click_signin_sync_starter.h

diff --git a/chrome/browser/ui/sync/one_click_signin_sync_starter.h b/chrome/browser/ui/sync/one_click_signin_sync_starter.h

index e56224240f20d5891530048fc6087cc2f0fb48c4..349a5393222a8ac32366371cc096eda4afbab2a7 100644

--- a/chrome/browser/ui/sync/one_click_signin_sync_starter.h

+++ b/chrome/browser/ui/sync/one_click_signin_sync_starter.h

@@ -134,7 +134,8 @@ class OneClickSigninSyncStarter : public SigninTracker::Observer,

void AccountAddedToCookie(const GoogleServiceAuthError& error) override;

// LoginUIService::Observer override.

- void OnSyncConfirmationUIClosed(bool configure_sync_first) override;

+ void OnSyncConfirmationUIClosed(

+ LoginUIService::SyncConfirmationUIClosedResults results) override;

#if defined(ENABLE_CONFIGURATION_POLICY)

// User input handler for the signin confirmation dialog.

@@ -218,6 +219,8 @@ class OneClickSigninSyncStarter : public SigninTracker::Observer,

// the default "You are signed in" message is displayed.

void DisplayFinalConfirmationBubble(const base::string16& custom_message);

+ void DisplayModalSyncConfirmationWindow();

// Loads the |continue_url_| in the current tab.

void LoadContinueUrl();