chrome/browser/ui/webui/signin/sync_confirmation_ui.h - Issue 1487283005: Implement the new Sync Confirmation dialog on Linux and Windows.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/webui/signin/sync_confirmation_ui.h

Issue 1487283005: Implement the new Sync Confirmation dialog on Linux and Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add some tests. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/webui/signin/sync_confirmation_handler.cc ('K') | « chrome/browser/ui/webui/signin/sync_confirmation_handler.cc ('k') | chrome/browser/ui/webui/signin/sync_confirmation_ui.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_UI_WEBUI_SIGNIN_SYNC_CONFIRMATION_UI_H_

	6 #define CHROME_BROWSER_UI_WEBUI_SIGNIN_SYNC_CONFIRMATION_UI_H_

	7

	8 #include "base/macros.h"

	9 #include "content/public/browser/web_ui_data_source.h"
	Dan Beam 2016/01/06 22:57:58 why is this web_ui_data_source.h? did you mean we why is this web_ui_data_source.h? did you mean web_ui.h? if you're trying to make content::WebUI exist you can just forward declare it here, i.e. namespace content { class WebUI; } anthonyvd 2016/01/08 22:39:42 I moved some things around and missed this. It's s Show quoted text On 2016/01/06 22:57:58, Dan Beam wrote: > why is this web_ui_data_source.h? did you mean web_ui.h? > > if you're trying to make content::WebUI exist you can just forward declare it > here, i.e. > > namespace content { > class WebUI; > } I moved some things around and missed this. It's still required in the .cc so moved it there.
	10 #include "ui/web_dialogs/web_dialog_ui.h"

	11

	12 class SyncConfirmationUI : public ui::WebDialogUI {

	13 public:

	14 explicit SyncConfirmationUI(content::WebUI* web_ui);

	15 ~SyncConfirmationUI() override {}

	16

	17 DISALLOW_COPY_AND_ASSIGN(SyncConfirmationUI);

	18 };

	19

	20 #endif // CHROME_BROWSER_UI_WEBUI_SIGNIN_SYNC_CONFIRMATION_UI_H_

OLD	NEW