Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Side by Side Diff: chrome/browser/ui/webui/signin/sync_confirmation_handler.h

Issue 1487283005: Implement the new Sync Confirmation dialog on Linux and Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add some tests. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CHROME_BROWSER_UI_WEBUI_SIGNIN_SYNC_CONFIRMATION_HANDLER_H_
6 #define CHROME_BROWSER_UI_WEBUI_SIGNIN_SYNC_CONFIRMATION_HANDLER_H_
7
8 #include "base/macros.h"
9 #include "base/values.h"
Dan Beam 2016/01/06 22:57:58 forward declare base::ListValue instead of includi
anthonyvd 2016/01/08 22:39:42 Done.
10 #include "components/signin/core/browser/account_tracker_service.h"
11 #include "content/public/browser/web_ui_message_handler.h"
12
13 class SyncConfirmationHandler : public content::WebUIMessageHandler,
14 public AccountTrackerService::Observer {
15 public:
16 SyncConfirmationHandler();
17 ~SyncConfirmationHandler() override;
18
Dan Beam 2016/01/06 22:57:58 // content::WebUIMessageHandler:
anthonyvd 2016/01/08 22:39:42 Done.
19 void RegisterMessages() override;
20
21 // AccountTrackerService::Observer:
22 void OnAccountUpdated(const AccountInfo& info) override;
23
24 private:
25 void HandleConfirmMessage(const base::ListValue* args);
Dan Beam 2016/01/06 22:57:58 these should be Handle + MessageName (without "Mes
anthonyvd 2016/01/08 22:39:42 Done.
26 void HandleUndoMessage(const base::ListValue* args);
27 void HandleInitializedMessage(const base::ListValue* args);
28 void HandleGoToSettingsMessage(const base::ListValue* args);
Dan Beam 2016/01/06 22:57:58 doc comments about what these do, i.e. // Handl
anthonyvd 2016/01/08 22:39:42 Done.
29
30 void SetUserImageURL(std::string url);
Dan Beam 2016/01/06 22:57:58 doc comment, shouldn't this be const std::string&
anthonyvd 2016/01/08 22:39:42 Done.
31
32 DISALLOW_COPY_AND_ASSIGN(SyncConfirmationHandler);
33 };
34
35 #endif // CHROME_BROWSER_UI_WEBUI_SIGNIN_SYNC_CONFIRMATION_HANDLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698