chrome/browser/resources/sync_confirmation/sync_confirmation.html - Issue 1487283005: Implement the new Sync Confirmation dialog on Linux and Windows.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/sync_confirmation/sync_confirmation.html

Issue 1487283005: Implement the new Sync Confirmation dialog on Linux and Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add some tests. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/sync_confirmation/sync_confirmation.css ('K') | « chrome/browser/resources/sync_confirmation/sync_confirmation.css ('k') | chrome/browser/resources/sync_confirmation/sync_confirmation.js » ('j') | chrome/browser/ui/webui/signin/sync_confirmation_handler.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>
	Dan Beam 2016/01/06 22:57:57 <!doctype html> before <html> <!doctype html> before <html> anthonyvd 2016/01/08 22:39:41 Done. Show quoted text On 2016/01/06 22:57:57, Dan Beam wrote: > <!doctype html> before <html> Done.
	2 <head>
	Robert Sesek 2016/01/06 19:30:08 Does this page display internationalized content? Does this page display internationalized content? If so, you should probably have a <meta charset="utf-8"> anthonyvd 2016/01/08 22:39:41 Done. Show quoted text On 2016/01/06 19:30:08, Robert Sesek wrote: > Does this page display internationalized content? If so, you should probably > have a <meta charset="utf-8"> Done.
	3 <link rel="stylesheet" type="text/css" href="sync-confirmation.css" media="s creen"></link>
	Dan Beam 2016/01/06 22:57:57 type="text/css" probably isn't necessary either type="text/css" probably isn't necessary either Dan Beam 2016/01/06 22:57:57 media="screen" isn't necessary unless you want to media="screen" isn't necessary unless you want to strip of all the CSS when printing or something... anthonyvd 2016/01/08 22:39:41 Done. Show quoted text On 2016/01/06 22:57:57, Dan Beam wrote: > type="text/css" probably isn't necessary either Done. anthonyvd 2016/01/08 22:39:41 Done. Show quoted text On 2016/01/06 22:57:57, Dan Beam wrote: > media="screen" isn't necessary unless you want to strip of all the CSS when > printing or something... Done.
	4 <script src="chrome://resources/js/cr.js"></script>

	5 <script src="chrome://resources/js/load_time_data.js"></script>

	6 <script src="chrome://resources/js/util.js"></script>

	7 <script type="text/javascript" src="sync-confirmation.js"></script>
	Dan Beam 2016/01/06 22:57:57 remove type="text/javascript" remove type="text/javascript" anthonyvd 2016/01/08 22:39:41 Done. Show quoted text On 2016/01/06 22:57:57, Dan Beam wrote: > remove type="text/javascript" Done.
	8 </head>

	9 <body>

	10 <div class="container">

	11 <div class="top-title-bar" i18n-content="syncConfirmationTitle"></div>

	12 <div class="details">

	13 <div class="picture-container">

	14 <div class="picture">

	15 <img id="profile-picture"></img>

	16 <div class="checkmark-bubble"></div>

	17 </div>

	18 </div>

	19 <div class="sync-message" i18n-values=".innerHTML:syncConfirmationBody"> </div>

	20 <div class="action-container">

	21 <div class="action-button-wrapper">

	22 <div class="action-button" id="confirmButton">

	23 <span class="action-button-label" i18n-content="syncConfirmationCo nfirmLabel"></span>

	24 </div>

	25 </div>

	26 <div class="link-wrapper">

	27 <span class="link" id="undoLink" i18n-content="syncConfirmationUndoL abel"></span>

	28 </div>

	29 </div>

	30 </div>

	31 </div>

	32 </body>

	33 <script src="chrome://sync-confirmation/strings.js"></script>

	34 <script src="chrome://resources/js/i18n_template.js"></script>

	35 </html>

OLD	NEW