chrome/browser/ui/webui/signin/sync_confirmation_ui.cc - Issue 1487283005: Implement the new Sync Confirmation dialog on Linux and Windows.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/webui/signin/sync_confirmation_ui.cc

Issue 1487283005: Implement the new Sync Confirmation dialog on Linux and Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/sync_confirmation/sync_confirmation.html ('K') | « chrome/browser/ui/webui/signin/sync_confirmation_ui.h ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser/ui/webui/signin/sync_confirmation_ui.h"

	6

	7 #include "chrome/browser/profiles/profile.h"

	8 #include "chrome/browser/ui/webui/signin/sync_confirmation_handler.h"

	9 #include "chrome/grit/generated_resources.h"

	10 #include "content/public/browser/web_ui.h"

	11 #include "content/public/browser/web_ui_data_source.h"

	12 #include "grit/browser_resources.h"

	13

	14 SyncConfirmationUI::SyncConfirmationUI(content::WebUI* web_ui)

	15 : WebDialogUI(web_ui) {

	16 Profile* profile = Profile::FromWebUI(web_ui);

	17 content::WebUIDataSource* source =

	18 content::WebUIDataSource::Create("sync-confirmation");
	Dan Beam 2016/01/21 03:57:33 please use kChromeUISyncConfirmationHost like ever please use kChromeUISyncConfirmationHost like everybody else seems to do: https://code.google.com/p/chromium/codesearch#search/&q=content::WebUIDataSou... anthonyvd 2016/01/21 22:36:11 Done. Show quoted text On 2016/01/21 03:57:33, Dan Beam wrote: > please use kChromeUISyncConfirmationHost like everybody else seems to do: > https://code.google.com/p/chromium/codesearch#search/&q=content::WebUIDataSou... Done.
	19 source->SetJsonPath("strings.js");

	20 source->SetDefaultResource(IDR_SYNC_CONFIRMATION_HTML);

	21 source->AddResourcePath("sync-confirmation.css", IDR_SYNC_CONFIRMATION_CSS);

	22 source->AddResourcePath("sync-confirmation.js", IDR_SYNC_CONFIRMATION_JS);
	Dan Beam 2016/01/21 03:57:33 replace - with _ in the file names replace - with _ in the file names anthonyvd 2016/01/21 22:36:11 Done. Show quoted text On 2016/01/21 03:57:33, Dan Beam wrote: > replace - with _ in the file names Done.
	23

	24 source->AddLocalizedString("syncConfirmationTitle",

	25 IDS_SYNC_CONFIRMATION_TITLE);

	26 source->AddLocalizedString("syncConfirmationBody",

	27 IDS_SYNC_CONFIRMATION_BODY);

	28 source->AddLocalizedString("syncConfirmationConfirmLabel",

	29 IDS_SYNC_CONFIRMATION_CONFIRM_BUTTON_LABEL);

	30 source->AddLocalizedString("syncConfirmationUndoLabel",

	31 IDS_SYNC_CONFIRMATION_UNDO_BUTTON_LABEL);

	32

	33 content::WebUIDataSource::Add(profile, source);

	34 web_ui->AddMessageHandler(new SyncConfirmationHandler);

	35 }

OLD	NEW