Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: chrome/browser/sync/test/integration/sync_test.cc

Issue 1487283005: Implement the new Sync Confirmation dialog on Linux and Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reverted a few sign changes missed in last patchset Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/sync/test/integration/sync_test.h" 5 #include "chrome/browser/sync/test/integration/sync_test.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <limits> 10 #include <limits>
(...skipping 602 matching lines...) Expand 10 before | Expand all | Expand 10 after
613 new P2PSyncRefresher(GetProfile(i), clients_[i]->service()); 613 new P2PSyncRefresher(GetProfile(i), clients_[i]->service());
614 } 614 }
615 615
616 // OneClickSigninSyncStarter observer is created with a real user sign in. 616 // OneClickSigninSyncStarter observer is created with a real user sign in.
617 // It is deleted on certain conditions which are not satisfied by our tests, 617 // It is deleted on certain conditions which are not satisfied by our tests,
618 // and this causes the SigninTracker observer to stay hanging at shutdown. 618 // and this causes the SigninTracker observer to stay hanging at shutdown.
619 // Calling LoginUIService::SyncConfirmationUIClosed forces the observer to 619 // Calling LoginUIService::SyncConfirmationUIClosed forces the observer to
620 // be removed. http://crbug.com/484388 620 // be removed. http://crbug.com/484388
621 for (int i = 0; i < num_clients_; ++i) { 621 for (int i = 0; i < num_clients_; ++i) {
622 LoginUIServiceFactory::GetForProfile(GetProfile(i))-> 622 LoginUIServiceFactory::GetForProfile(GetProfile(i))->
623 SyncConfirmationUIClosed(false /* configure_sync_first */); 623 SyncConfirmationUIClosed(LoginUIService::SYNC_WITH_DEFAULT_SETTINGS);
624 } 624 }
625 } 625 }
626 626
627 return true; 627 return true;
628 } 628 }
629 629
630 void SyncTest::TearDownOnMainThread() { 630 void SyncTest::TearDownOnMainThread() {
631 for (size_t i = 0; i < clients_.size(); ++i) { 631 for (size_t i = 0; i < clients_.size(); ++i) {
632 clients_[i]->service()->RequestStop(ProfileSyncService::CLEAR_DATA); 632 clients_[i]->service()->RequestStop(ProfileSyncService::CLEAR_DATA);
633 } 633 }
(...skipping 467 matching lines...) Expand 10 before | Expand all | Expand 10 after
1101 1101
1102 void SyncTest::TriggerSyncForModelTypes(int index, 1102 void SyncTest::TriggerSyncForModelTypes(int index,
1103 syncer::ModelTypeSet model_types) { 1103 syncer::ModelTypeSet model_types) {
1104 GetSyncService(index)->TriggerRefresh(model_types); 1104 GetSyncService(index)->TriggerRefresh(model_types);
1105 } 1105 }
1106 1106
1107 void SyncTest::SetPreexistingPreferencesFileContents( 1107 void SyncTest::SetPreexistingPreferencesFileContents(
1108 const std::string& contents) { 1108 const std::string& contents) {
1109 preexisting_preferences_file_contents_ = contents; 1109 preexisting_preferences_file_contents_ = contents;
1110 } 1110 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698