Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 1487273003: Make WebPageSerializerImpl to escape URL attribute values in result. (Closed)

Created:
5 years ago by yosin_UTC9
Modified:
5 years ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2526
Target Ref:
refs/pending/branch-heads/2526
Project:
chromium
Visibility:
Public.

Description

Make WebPageSerializerImpl to escape URL attribute values in result. This patch makes |WebPageSerializerImpl| to escape URL attribute values rather than directly output URL attribute values into result. BUG=542054 TEST=webkit_unit_tests --gtest_filter=WebPageSerializerTest.URLAttributeValues Review URL: https://codereview.chromium.org/1398453005 Cr-Commit-Position: refs/heads/master@{#353712} (cherry picked from commit b770d85e37b2d0e248f04cf20606a2f3871ef039) Committed: https://chromium.googlesource.com/chromium/src/+/947b9d85a5e06ad7f3d658682db39443d2028c08

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -3 lines) Patch
M third_party/WebKit/Source/web/WebPageSerializerImpl.cpp View 3 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebPageSerializerTest.cpp View 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/web/tests/data/pageserialization/url_attribute_values.html View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
yosin_UTC9
5 years ago (2015-12-02 08:46:28 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
947b9d85a5e06ad7f3d658682db39443d2028c08.

Powered by Google App Engine
This is Rietveld 408576698