Explicitly detach remote window from its frame.

Explicitly detach remote window from its frame.

See RemoteFrame::setView() comment explaining why this is needed
over RemoteFrames.

R=haraken,dcheng
BUG=

Committed: https://crrev.com/aae2523be94a72e94f309238eaab3c3372483c75
Cr-Commit-Position: refs/heads/master@{#363150}

[sof, 2015-12-03 13:32:30]

sigbjornf@opera.com changed reviewers:
+ dcheng@chromium.org, oilpan-reviews@chromium.org

[sof, 2015-12-03 13:32:31]

please take a look.

Example leaks without this one,


http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...

[haraken, 2015-12-03 15:05:03]

LGTM

I'm curious why we don't need to add the detachment logic for LocalDOMWindow as
well.

[sof, 2015-12-03 15:10:33]

On 2015/12/03 15:05:03, haraken wrote:
> LGTM
> 
> I'm curious why we don't need to add the detachment logic for LocalDOMWindow
as
> well.

It is in place already, see LocalFrameLifecycleObserver::contextDestroyed()
which is notified via LocalFrame::detach().

[dcheng, 2015-12-04 02:42:29]

dcheng@chromium.org changed reviewers:
+ haraken@chromium.org

[dcheng, 2015-12-04 02:42:30]

LGTM, thanks for catching this. I guess we didn't notice it since Oilpan isn't
default enabled yet?

[sof, 2015-12-04 06:18:26]

On 2015/12/04 02:42:30, dcheng wrote:
> LGTM, thanks for catching this. I guess we didn't notice it since Oilpan isn't
> default enabled yet?

Yes, that would be the main reason. Our leak-detector Oilpan bot has picked up
on most leaks, but this one needed LSan.

[sof, 2015-12-04 06:18:44]

Description was changed from

==========
Explicitly detach remote window from its frame.

See RemoteFrame::setView() comment explaining why this is needed
over RemoteFrames.

R=
BUG=
==========

to

==========
Explicitly detach remote window from its frame.

See RemoteFrame::setView() comment explaining why this is needed
over RemoteFrames.

R=haraken,dcheng
BUG=
==========

[sof, 2015-12-04 06:18:53]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2015-12-04 06:19:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1487253006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1487253006/1

[commit-bot: I haz the power, 2015-12-04 06:23:19]

Description was changed from

==========
Explicitly detach remote window from its frame.

See RemoteFrame::setView() comment explaining why this is needed
over RemoteFrames.

R=haraken,dcheng
BUG=
==========

to

==========
Explicitly detach remote window from its frame.

See RemoteFrame::setView() comment explaining why this is needed
over RemoteFrames.

R=haraken,dcheng
BUG=
==========

[commit-bot: I haz the power, 2015-12-04 06:23:20]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-04 06:24:26]

Description was changed from

==========
Explicitly detach remote window from its frame.

See RemoteFrame::setView() comment explaining why this is needed
over RemoteFrames.

R=haraken,dcheng
BUG=
==========

to

==========
Explicitly detach remote window from its frame.

See RemoteFrame::setView() comment explaining why this is needed
over RemoteFrames.

R=haraken,dcheng
BUG=

Committed: https://crrev.com/aae2523be94a72e94f309238eaab3c3372483c75
Cr-Commit-Position: refs/heads/master@{#363150}
==========

[commit-bot: I haz the power, 2015-12-04 06:24:27]

Patchset 1 (id:??) landed as
https://crrev.com/aae2523be94a72e94f309238eaab3c3372483c75
Cr-Commit-Position: refs/heads/master@{#363150}