Issue 148723003: Make generated hosted app icons have white background.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 148723003: Make generated hosted app icons have white background. (Closed)

Created:
6 years, 11 months ago by calamity

Modified:
6 years, 10 months ago

Reviewers:
benwells

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@reattempt_icon_generation

Visibility:
Public.

Make generated hosted app icons have white background. This CL changes the transparent background of icons generated by the "Create app from this website" button into solid white. BUG=315632 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247629

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -10 lines)			Patch
	M	chrome/browser/extensions/tab_helper.cc	View	1	3 chunks	+29 lines, -10 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/148723003/60001

6 years, 10 months ago (2014-01-28 18:29:30 UTC) #3

Message was sent while issue was closed.

Change committed as 247629