Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Unified Diff: chrome/browser/sync/test/integration/two_client_passwords_sync_test.cc

Issue 148723002: [sync] Eliminate Await*SyncCompletion methods in integration tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address feedback Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/test/integration/two_client_passwords_sync_test.cc
diff --git a/chrome/browser/sync/test/integration/two_client_passwords_sync_test.cc b/chrome/browser/sync/test/integration/two_client_passwords_sync_test.cc
index b3bd68dece5f393f432e358f26d62e010225a9c2..da167bfb7cf896026a24a450a7e70ea88f6aefb4 100644
--- a/chrome/browser/sync/test/integration/two_client_passwords_sync_test.cc
+++ b/chrome/browser/sync/test/integration/two_client_passwords_sync_test.cc
@@ -80,7 +80,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientPasswordsSyncTest, DisablePasswords) {
AddLogin(GetPasswordStore(0), form);
ASSERT_EQ(1, GetPasswordCount(0));
- ASSERT_TRUE(GetClient(0)->AwaitFullSyncCompletion());
+ ASSERT_TRUE(GetClient(0)->AwaitCommitActivityCompletion());
ASSERT_TRUE(ProfileContainsSamePasswordFormsAsVerifier(0));
ASSERT_FALSE(ProfileContainsSamePasswordFormsAsVerifier(1));
@@ -102,7 +102,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientPasswordsSyncTest, DisableSync) {
AddLogin(GetPasswordStore(0), form);
ASSERT_EQ(1, GetPasswordCount(0));
- ASSERT_TRUE(GetClient(0)->AwaitFullSyncCompletion());
+ ASSERT_TRUE(GetClient(0)->AwaitCommitActivityCompletion());
ASSERT_TRUE(ProfileContainsSamePasswordFormsAsVerifier(0));
ASSERT_FALSE(ProfileContainsSamePasswordFormsAsVerifier(1));
@@ -122,7 +122,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientPasswordsSyncTest, SetPassphrase) {
ASSERT_TRUE(GetClient(1)->AwaitPassphraseRequired());
ASSERT_TRUE(SetDecryptionPassphrase(1, kValidPassphrase));
ASSERT_TRUE(GetClient(1)->AwaitPassphraseAccepted());
- ASSERT_TRUE(GetClient(1)->AwaitFullSyncCompletion());
+ ASSERT_TRUE(GetClient(1)->AwaitCommitActivityCompletion());
}
IN_PROC_BROWSER_TEST_F(TwoClientPasswordsSyncTest,
@@ -236,13 +236,13 @@ IN_PROC_BROWSER_TEST_F(TwoClientPasswordsSyncTest,
ASSERT_TRUE(GetClient(0)->SetupSync());
SetEncryptionPassphrase(0, kValidPassphrase, ProfileSyncService::EXPLICIT);
ASSERT_TRUE(GetClient(0)->AwaitPassphraseAccepted());
- ASSERT_TRUE(GetClient(0)->AwaitFullSyncCompletion());
+ ASSERT_TRUE(GetClient(0)->AwaitCommitActivityCompletion());
ASSERT_FALSE(GetClient(1)->SetupSync());
ASSERT_TRUE(GetClient(1)->AwaitPassphraseRequired());
ASSERT_TRUE(SetDecryptionPassphrase(1, kValidPassphrase));
ASSERT_TRUE(GetClient(1)->AwaitPassphraseAccepted());
- ASSERT_TRUE(GetClient(1)->AwaitFullSyncCompletion());
+ ASSERT_TRUE(GetClient(1)->AwaitCommitActivityCompletion());
// Following ensures types are enabled and active (see bug 87572).
syncer::ModelSafeRoutingInfo routes;
@@ -260,7 +260,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientPasswordsSyncTest,
ASSERT_TRUE(GetClient(0)->SetupSync());
SetEncryptionPassphrase(0, kValidPassphrase, ProfileSyncService::EXPLICIT);
ASSERT_TRUE(GetClient(0)->AwaitPassphraseAccepted());
- ASSERT_TRUE(GetClient(0)->AwaitFullSyncCompletion());
+ ASSERT_TRUE(GetClient(0)->AwaitCommitActivityCompletion());
// Setup 1 with a different passphrase, so that it fails to sync.
ASSERT_FALSE(GetClient(1)->SetupSync());
@@ -273,7 +273,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientPasswordsSyncTest,
AddLogin(GetVerifierPasswordStore(), form0);
AddLogin(GetPasswordStore(0), form0);
- ASSERT_TRUE(GetClient(0)->AwaitFullSyncCompletion());
+ ASSERT_TRUE(GetClient(0)->AwaitCommitActivityCompletion());
// Password hasn't been synced to 1 yet.
ASSERT_FALSE(AllProfilesContainSamePasswordFormsAsVerifier());

Powered by Google App Engine
This is Rietveld 408576698