chrome/browser/sync/test/integration/sync_exponential_backoff_test.cc - Issue 148723002: [sync] Eliminate Await*SyncCompletion methods in integration tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/sync_exponential_backoff_test.cc

Issue 148723002: [sync] Eliminate Await*SyncCompletion methods in integration tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address feedback Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/test/integration/sync_errors_test.cc ('k') | chrome/browser/sync/test/integration/two_client_app_list_sync_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/sync_exponential_backoff_test.cc

diff --git a/chrome/browser/sync/test/integration/sync_exponential_backoff_test.cc b/chrome/browser/sync/test/integration/sync_exponential_backoff_test.cc

index c10fe57a69c4c0d50bbe1b6f9bc5b37a6e5b677e..16e5a092741d454c56c1e4c50777a46d02f1e6a0 100644

--- a/chrome/browser/sync/test/integration/sync_exponential_backoff_test.cc

+++ b/chrome/browser/sync/test/integration/sync_exponential_backoff_test.cc

@@ -62,7 +62,7 @@ IN_PROC_BROWSER_TEST_F(SyncExponentialBackoffTest, OfflineToOnline) {

// Add an item and ensure that sync is successful.

ASSERT_TRUE(AddFolder(0, 0, L"folder1"));

- ASSERT_TRUE(GetClient(0)->AwaitFullSyncCompletion());

+ ASSERT_TRUE(GetClient(0)->AwaitCommitActivityCompletion());

// Trigger a network error at the client side.

DisableNetwork(GetProfile(0));

@@ -80,7 +80,7 @@ IN_PROC_BROWSER_TEST_F(SyncExponentialBackoffTest, OfflineToOnline) {

EnableNetwork(GetProfile(0));

// Verify that sync was able to recover.

- ASSERT_TRUE(GetClient(0)->AwaitFullSyncCompletion());

+ ASSERT_TRUE(GetClient(0)->AwaitCommitActivityCompletion());

ASSERT_TRUE(ModelMatchesVerifier(0));

}

@@ -89,7 +89,7 @@ IN_PROC_BROWSER_TEST_F(SyncExponentialBackoffTest, TransientErrorTest) {

// Add an item and ensure that sync is successful.

ASSERT_TRUE(AddFolder(0, 0, L"folder1"));

- ASSERT_TRUE(GetClient(0)->AwaitFullSyncCompletion());

+ ASSERT_TRUE(GetClient(0)->AwaitCommitActivityCompletion());

// Trigger a transient error on the server.

TriggerTransientError();