Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2386)

Unified Diff: chrome/browser/sync/test/integration/migration_test.cc

Issue 148723002: [sync] Eliminate Await*SyncCompletion methods in integration tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address feedback Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/test/integration/migration_test.cc
diff --git a/chrome/browser/sync/test/integration/migration_test.cc b/chrome/browser/sync/test/integration/migration_test.cc
index b1956c26180c108396a8aa7f5fa509cf2d084fd5..a63d0d45be82aad06a96a949b7b4fa23cc1de094 100644
--- a/chrome/browser/sync/test/integration/migration_test.cc
+++ b/chrome/browser/sync/test/integration/migration_test.cc
@@ -95,7 +95,13 @@ class MigrationChecker : public StatusChangeChecker,
" does not contain ")
<< syncer::ModelTypeSetToString(expected_types_);
return all_expected_types_migrated &&
- !harness_->HasPendingBackendMigration();
+ !HasPendingBackendMigration();
+ }
+
+ bool HasPendingBackendMigration() const {
+ browser_sync::BackendMigrator* migrator =
+ harness_->service()->GetBackendMigratorForTest();
+ return migrator && migrator->state() != browser_sync::BackendMigrator::IDLE;
}
void set_expected_types(syncer::ModelTypeSet expected_types) {
@@ -107,7 +113,7 @@ class MigrationChecker : public StatusChangeChecker,
}
virtual void OnMigrationStateChange() OVERRIDE {
- if (harness_->HasPendingBackendMigration()) {
+ if (HasPendingBackendMigration()) {
// A new bunch of data types are in the process of being migrated. Merge
// them into |pending_types_|.
pending_types_.PutAll(
@@ -229,14 +235,6 @@ class MigrationTest : public SyncTest {
checker->set_expected_types(migrate_types);
if (!checker->IsExitConditionSatisfied())
ASSERT_TRUE(GetClient(i)->AwaitStatusChange(checker, "AwaitMigration"));
- // We must use AwaitDataSyncCompletion rather than the more common
- // AwaitFullSyncCompletion. As long as crbug.com/97780 is open, we will
- // rely on self-notifications to ensure that progress markers are updated,
- // which allows AwaitFullSyncCompletion to return. However, in some
- // migration tests these notifications are completely disabled, so the
- // progress markers do not get updated. This is why we must use the less
- // strict condition, AwaitDataSyncCompletion.
- ASSERT_TRUE(GetClient(i)->AwaitDataSyncCompletion());
}
}

Powered by Google App Engine
This is Rietveld 408576698