Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Side by Side Diff: chrome/browser/sync/test/integration/two_client_search_engines_sync_test.cc

Issue 148723002: [sync] Eliminate Await*SyncCompletion methods in integration tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address feedback Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/strings/utf_string_conversions.h" 5 #include "base/strings/utf_string_conversions.h"
6 #include "chrome/browser/search_engines/template_url.h" 6 #include "chrome/browser/search_engines/template_url.h"
7 #include "chrome/browser/search_engines/template_url_service.h" 7 #include "chrome/browser/search_engines/template_url_service.h"
8 #include "chrome/browser/search_engines/template_url_service_factory.h" 8 #include "chrome/browser/search_engines/template_url_service_factory.h"
9 #include "chrome/browser/sync/test/integration/profile_sync_service_harness.h" 9 #include "chrome/browser/sync/test/integration/profile_sync_service_harness.h"
10 #include "chrome/browser/sync/test/integration/search_engines_helper.h" 10 #include "chrome/browser/sync/test/integration/search_engines_helper.h"
(...skipping 174 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 } 185 }
186 186
187 // TCM ID - 8906436. 187 // TCM ID - 8906436.
188 IN_PROC_BROWSER_TEST_F(TwoClientSearchEnginesSyncTest, DisableSync) { 188 IN_PROC_BROWSER_TEST_F(TwoClientSearchEnginesSyncTest, DisableSync) {
189 ASSERT_TRUE(SetupSync()); 189 ASSERT_TRUE(SetupSync());
190 ASSERT_TRUE(search_engines_helper::AllServicesMatch()); 190 ASSERT_TRUE(search_engines_helper::AllServicesMatch());
191 191
192 ASSERT_TRUE(GetClient(1)->DisableSyncForAllDatatypes()); 192 ASSERT_TRUE(GetClient(1)->DisableSyncForAllDatatypes());
193 search_engines_helper::AddSearchEngine(0, 0); 193 search_engines_helper::AddSearchEngine(0, 0);
194 ASSERT_TRUE( 194 ASSERT_TRUE(
195 GetClient(0)->AwaitFullSyncCompletion()); 195 GetClient(0)->AwaitCommitActivityCompletion());
196 ASSERT_TRUE(search_engines_helper::ServiceMatchesVerifier(0)); 196 ASSERT_TRUE(search_engines_helper::ServiceMatchesVerifier(0));
197 ASSERT_FALSE(search_engines_helper::ServiceMatchesVerifier(1)); 197 ASSERT_FALSE(search_engines_helper::ServiceMatchesVerifier(1));
198 198
199 ASSERT_TRUE(GetClient(1)->EnableSyncForAllDatatypes()); 199 ASSERT_TRUE(GetClient(1)->EnableSyncForAllDatatypes());
200 ASSERT_TRUE(AwaitQuiescence()); 200 ASSERT_TRUE(AwaitQuiescence());
201 ASSERT_TRUE(search_engines_helper::AllServicesMatch()); 201 ASSERT_TRUE(search_engines_helper::AllServicesMatch());
202 } 202 }
203 203
204 // TCM ID - 8891809. 204 // TCM ID - 8891809.
205 IN_PROC_BROWSER_TEST_F(TwoClientSearchEnginesSyncTest, SyncDefault) { 205 IN_PROC_BROWSER_TEST_F(TwoClientSearchEnginesSyncTest, SyncDefault) {
(...skipping 26 matching lines...) Expand all
232 ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1))); 232 ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1)));
233 ASSERT_TRUE(search_engines_helper::AllServicesMatch()); 233 ASSERT_TRUE(search_engines_helper::AllServicesMatch());
234 234
235 // Change the default on the first client and delete the old default. 235 // Change the default on the first client and delete the old default.
236 search_engines_helper::ChangeDefaultSearchProvider(0, 1); 236 search_engines_helper::ChangeDefaultSearchProvider(0, 1);
237 search_engines_helper::DeleteSearchEngineBySeed(0, 0); 237 search_engines_helper::DeleteSearchEngineBySeed(0, 0);
238 ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1))); 238 ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1)));
239 239
240 ASSERT_TRUE(search_engines_helper::AllServicesMatch()); 240 ASSERT_TRUE(search_engines_helper::AllServicesMatch());
241 } 241 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698