Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Side by Side Diff: chrome/browser/sync/test/integration/two_client_extensions_sync_test.cc

Issue 148723002: [sync] Eliminate Await*SyncCompletion methods in integration tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address feedback Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/basictypes.h" 5 #include "base/basictypes.h"
6 #include "chrome/browser/sync/test/integration/extensions_helper.h" 6 #include "chrome/browser/sync/test/integration/extensions_helper.h"
7 #include "chrome/browser/sync/test/integration/profile_sync_service_harness.h" 7 #include "chrome/browser/sync/test/integration/profile_sync_service_harness.h"
8 #include "chrome/browser/sync/test/integration/sync_test.h" 8 #include "chrome/browser/sync/test/integration/sync_test.h"
9 9
10 using extensions_helper::AllProfilesHaveSameExtensionsAsVerifier; 10 using extensions_helper::AllProfilesHaveSameExtensionsAsVerifier;
(...skipping 230 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 241
242 // TCM ID - 3732278. 242 // TCM ID - 3732278.
243 IN_PROC_BROWSER_TEST_F(TwoClientExtensionsSyncTest, DisableExtensions) { 243 IN_PROC_BROWSER_TEST_F(TwoClientExtensionsSyncTest, DisableExtensions) {
244 ASSERT_TRUE(SetupSync()); 244 ASSERT_TRUE(SetupSync());
245 ASSERT_TRUE(AllProfilesHaveSameExtensionsAsVerifier()); 245 ASSERT_TRUE(AllProfilesHaveSameExtensionsAsVerifier());
246 246
247 ASSERT_TRUE(GetClient(1)->DisableSyncForDatatype(syncer::EXTENSIONS)); 247 ASSERT_TRUE(GetClient(1)->DisableSyncForDatatype(syncer::EXTENSIONS));
248 InstallExtension(GetProfile(0), 1); 248 InstallExtension(GetProfile(0), 1);
249 InstallExtension(verifier(), 1); 249 InstallExtension(verifier(), 1);
250 ASSERT_TRUE( 250 ASSERT_TRUE(
251 GetClient(0)->AwaitFullSyncCompletion()); 251 GetClient(0)->AwaitCommitActivityCompletion());
252 ASSERT_FALSE(AllProfilesHaveSameExtensionsAsVerifier()); 252 ASSERT_FALSE(AllProfilesHaveSameExtensionsAsVerifier());
253 253
254 ASSERT_TRUE(GetClient(1)->EnableSyncForDatatype(syncer::EXTENSIONS)); 254 ASSERT_TRUE(GetClient(1)->EnableSyncForDatatype(syncer::EXTENSIONS));
255 ASSERT_TRUE(AwaitQuiescence()); 255 ASSERT_TRUE(AwaitQuiescence());
256 InstallExtensionsPendingForSync(GetProfile(0)); 256 InstallExtensionsPendingForSync(GetProfile(0));
257 InstallExtensionsPendingForSync(GetProfile(1)); 257 InstallExtensionsPendingForSync(GetProfile(1));
258 InstallExtensionsPendingForSync(verifier()); 258 InstallExtensionsPendingForSync(verifier());
259 ASSERT_TRUE(AllProfilesHaveSameExtensionsAsVerifier()); 259 ASSERT_TRUE(AllProfilesHaveSameExtensionsAsVerifier());
260 } 260 }
261 261
262 // TCM ID - 3606290. 262 // TCM ID - 3606290.
263 IN_PROC_BROWSER_TEST_F(TwoClientExtensionsSyncTest, DisableSync) { 263 IN_PROC_BROWSER_TEST_F(TwoClientExtensionsSyncTest, DisableSync) {
264 ASSERT_TRUE(SetupSync()); 264 ASSERT_TRUE(SetupSync());
265 ASSERT_TRUE(AllProfilesHaveSameExtensionsAsVerifier()); 265 ASSERT_TRUE(AllProfilesHaveSameExtensionsAsVerifier());
266 266
267 ASSERT_TRUE(GetClient(1)->DisableSyncForAllDatatypes()); 267 ASSERT_TRUE(GetClient(1)->DisableSyncForAllDatatypes());
268 InstallExtension(GetProfile(0), 0); 268 InstallExtension(GetProfile(0), 0);
269 InstallExtension(verifier(), 0); 269 InstallExtension(verifier(), 0);
270 ASSERT_TRUE( 270 ASSERT_TRUE(
271 GetClient(0)->AwaitFullSyncCompletion()); 271 GetClient(0)->AwaitCommitActivityCompletion());
272 ASSERT_TRUE(HasSameExtensionsAsVerifier(0)); 272 ASSERT_TRUE(HasSameExtensionsAsVerifier(0));
273 ASSERT_FALSE(HasSameExtensionsAsVerifier(1)); 273 ASSERT_FALSE(HasSameExtensionsAsVerifier(1));
274 274
275 ASSERT_TRUE(GetClient(1)->EnableSyncForAllDatatypes()); 275 ASSERT_TRUE(GetClient(1)->EnableSyncForAllDatatypes());
276 ASSERT_TRUE(AwaitQuiescence()); 276 ASSERT_TRUE(AwaitQuiescence());
277 InstallExtensionsPendingForSync(GetProfile(0)); 277 InstallExtensionsPendingForSync(GetProfile(0));
278 InstallExtensionsPendingForSync(GetProfile(1)); 278 InstallExtensionsPendingForSync(GetProfile(1));
279 InstallExtensionsPendingForSync(verifier()); 279 InstallExtensionsPendingForSync(verifier());
280 ASSERT_TRUE(AllProfilesHaveSameExtensionsAsVerifier()); 280 ASSERT_TRUE(AllProfilesHaveSameExtensionsAsVerifier());
281 } 281 }
(...skipping 17 matching lines...) Expand all
299 299
300 UninstallExtension(GetProfile(0), 0); 300 UninstallExtension(GetProfile(0), 0);
301 UninstallExtension(verifier(), 0); 301 UninstallExtension(verifier(), 0);
302 302
303 ASSERT_TRUE(AwaitQuiescence()); 303 ASSERT_TRUE(AwaitQuiescence());
304 ASSERT_TRUE(AllProfilesHaveSameExtensionsAsVerifier()); 304 ASSERT_TRUE(AllProfilesHaveSameExtensionsAsVerifier());
305 } 305 }
306 306
307 // TODO(akalin): Add tests exercising: 307 // TODO(akalin): Add tests exercising:
308 // - Offline installation/uninstallation behavior 308 // - Offline installation/uninstallation behavior
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698