Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Side by Side Diff: chrome/browser/sync/test/integration/single_client_themes_sync_test.cc

Issue 148723002: [sync] Eliminate Await*SyncCompletion methods in integration tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address feedback Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/basictypes.h" 5 #include "base/basictypes.h"
6 #include "chrome/browser/sync/test/integration/profile_sync_service_harness.h" 6 #include "chrome/browser/sync/test/integration/profile_sync_service_harness.h"
7 #include "chrome/browser/sync/test/integration/sync_test.h" 7 #include "chrome/browser/sync/test/integration/sync_test.h"
8 #include "chrome/browser/sync/test/integration/themes_helper.h" 8 #include "chrome/browser/sync/test/integration/themes_helper.h"
9 9
10 using themes_helper::GetCustomTheme; 10 using themes_helper::GetCustomTheme;
(...skipping 22 matching lines...) Expand all
33 ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; 33 ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
34 34
35 ASSERT_FALSE(UsingCustomTheme(GetProfile(0))); 35 ASSERT_FALSE(UsingCustomTheme(GetProfile(0)));
36 ASSERT_FALSE(UsingCustomTheme(verifier())); 36 ASSERT_FALSE(UsingCustomTheme(verifier()));
37 37
38 UseCustomTheme(GetProfile(0), 0); 38 UseCustomTheme(GetProfile(0), 0);
39 UseCustomTheme(verifier(), 0); 39 UseCustomTheme(verifier(), 0);
40 ASSERT_EQ(GetCustomTheme(0), GetThemeID(GetProfile(0))); 40 ASSERT_EQ(GetCustomTheme(0), GetThemeID(GetProfile(0)));
41 ASSERT_EQ(GetCustomTheme(0), GetThemeID(verifier())); 41 ASSERT_EQ(GetCustomTheme(0), GetThemeID(verifier()));
42 42
43 ASSERT_TRUE(GetClient(0)->AwaitFullSyncCompletion()); 43 ASSERT_TRUE(GetClient(0)->AwaitCommitActivityCompletion());
44 44
45 ASSERT_EQ(GetCustomTheme(0), GetThemeID(GetProfile(0))); 45 ASSERT_EQ(GetCustomTheme(0), GetThemeID(GetProfile(0)));
46 ASSERT_EQ(GetCustomTheme(0), GetThemeID(verifier())); 46 ASSERT_EQ(GetCustomTheme(0), GetThemeID(verifier()));
47 } 47 }
48 48
49 // TODO(sync): Fails on Chrome OS. See http://crbug.com/84575. 49 // TODO(sync): Fails on Chrome OS. See http://crbug.com/84575.
50 #if defined(OS_CHROMEOS) 50 #if defined(OS_CHROMEOS)
51 IN_PROC_BROWSER_TEST_F(SingleClientThemesSyncTest, DISABLED_NativeTheme) { 51 IN_PROC_BROWSER_TEST_F(SingleClientThemesSyncTest, DISABLED_NativeTheme) {
52 #else 52 #else
53 IN_PROC_BROWSER_TEST_F(SingleClientThemesSyncTest, NativeTheme) { 53 IN_PROC_BROWSER_TEST_F(SingleClientThemesSyncTest, NativeTheme) {
54 #endif // OS_CHROMEOS 54 #endif // OS_CHROMEOS
55 ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; 55 ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
56 56
57 UseCustomTheme(GetProfile(0), 0); 57 UseCustomTheme(GetProfile(0), 0);
58 UseCustomTheme(verifier(), 0); 58 UseCustomTheme(verifier(), 0);
59 ASSERT_FALSE(UsingNativeTheme(GetProfile(0))); 59 ASSERT_FALSE(UsingNativeTheme(GetProfile(0)));
60 ASSERT_FALSE(UsingNativeTheme(verifier())); 60 ASSERT_FALSE(UsingNativeTheme(verifier()));
61 61
62 ASSERT_TRUE(GetClient(0)->AwaitFullSyncCompletion()); 62 ASSERT_TRUE(GetClient(0)->AwaitCommitActivityCompletion());
63 63
64 UseNativeTheme(GetProfile(0)); 64 UseNativeTheme(GetProfile(0));
65 UseNativeTheme(verifier()); 65 UseNativeTheme(verifier());
66 ASSERT_TRUE(UsingNativeTheme(GetProfile(0))); 66 ASSERT_TRUE(UsingNativeTheme(GetProfile(0)));
67 ASSERT_TRUE(UsingNativeTheme(verifier())); 67 ASSERT_TRUE(UsingNativeTheme(verifier()));
68 68
69 ASSERT_TRUE(GetClient(0)->AwaitFullSyncCompletion()); 69 ASSERT_TRUE(GetClient(0)->AwaitCommitActivityCompletion());
70 70
71 ASSERT_TRUE(UsingNativeTheme(GetProfile(0))); 71 ASSERT_TRUE(UsingNativeTheme(GetProfile(0)));
72 ASSERT_TRUE(UsingNativeTheme(verifier())); 72 ASSERT_TRUE(UsingNativeTheme(verifier()));
73 } 73 }
74 74
75 IN_PROC_BROWSER_TEST_F(SingleClientThemesSyncTest, DefaultTheme) { 75 IN_PROC_BROWSER_TEST_F(SingleClientThemesSyncTest, DefaultTheme) {
76 ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; 76 ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
77 77
78 UseCustomTheme(GetProfile(0), 0); 78 UseCustomTheme(GetProfile(0), 0);
79 UseCustomTheme(verifier(), 0); 79 UseCustomTheme(verifier(), 0);
80 ASSERT_FALSE(UsingDefaultTheme(GetProfile(0))); 80 ASSERT_FALSE(UsingDefaultTheme(GetProfile(0)));
81 ASSERT_FALSE(UsingDefaultTheme(verifier())); 81 ASSERT_FALSE(UsingDefaultTheme(verifier()));
82 82
83 ASSERT_TRUE(GetClient(0)->AwaitFullSyncCompletion()); 83 ASSERT_TRUE(GetClient(0)->AwaitCommitActivityCompletion());
84 84
85 UseDefaultTheme(GetProfile(0)); 85 UseDefaultTheme(GetProfile(0));
86 UseDefaultTheme(verifier()); 86 UseDefaultTheme(verifier());
87 ASSERT_TRUE(UsingDefaultTheme(GetProfile(0))); 87 ASSERT_TRUE(UsingDefaultTheme(GetProfile(0)));
88 ASSERT_TRUE(UsingDefaultTheme(verifier())); 88 ASSERT_TRUE(UsingDefaultTheme(verifier()));
89 89
90 ASSERT_TRUE(GetClient(0)->AwaitFullSyncCompletion()); 90 ASSERT_TRUE(GetClient(0)->AwaitCommitActivityCompletion());
91 91
92 ASSERT_TRUE(UsingDefaultTheme(GetProfile(0))); 92 ASSERT_TRUE(UsingDefaultTheme(GetProfile(0)));
93 ASSERT_TRUE(UsingDefaultTheme(verifier())); 93 ASSERT_TRUE(UsingDefaultTheme(verifier()));
94 } 94 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698