Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: chrome/browser/sync/test/integration/single_client_apps_sync_test.cc

Issue 148723002: [sync] Eliminate Await*SyncCompletion methods in integration tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address feedback Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/basictypes.h" 5 #include "base/basictypes.h"
6 #include "chrome/browser/sync/test/integration/apps_helper.h" 6 #include "chrome/browser/sync/test/integration/apps_helper.h"
7 #include "chrome/browser/sync/test/integration/profile_sync_service_harness.h" 7 #include "chrome/browser/sync/test/integration/profile_sync_service_harness.h"
8 #include "chrome/browser/sync/test/integration/sync_test.h" 8 #include "chrome/browser/sync/test/integration/sync_test.h"
9 9
10 using apps_helper::AllProfilesHaveSameAppsAsVerifier; 10 using apps_helper::AllProfilesHaveSameAppsAsVerifier;
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 57
58 IN_PROC_BROWSER_TEST_F(SingleClientAppsSyncTest, InstallSomeLegacyApps) { 58 IN_PROC_BROWSER_TEST_F(SingleClientAppsSyncTest, InstallSomeLegacyApps) {
59 ASSERT_TRUE(SetupSync()); 59 ASSERT_TRUE(SetupSync());
60 60
61 const int kNumApps = 5; 61 const int kNumApps = 5;
62 for (int i = 0; i < kNumApps; ++i) { 62 for (int i = 0; i < kNumApps; ++i) {
63 InstallApp(GetProfile(0), i); 63 InstallApp(GetProfile(0), i);
64 InstallApp(verifier(), i); 64 InstallApp(verifier(), i);
65 } 65 }
66 66
67 ASSERT_TRUE(GetClient(0)->AwaitFullSyncCompletion()); 67 ASSERT_TRUE(GetClient(0)->AwaitCommitActivityCompletion());
68 68
69 ASSERT_TRUE(AllProfilesHaveSameAppsAsVerifier()); 69 ASSERT_TRUE(AllProfilesHaveSameAppsAsVerifier());
70 } 70 }
71 71
72 IN_PROC_BROWSER_TEST_F(SingleClientAppsSyncTest, InstallSomePlatformApps) { 72 IN_PROC_BROWSER_TEST_F(SingleClientAppsSyncTest, InstallSomePlatformApps) {
73 ASSERT_TRUE(SetupSync()); 73 ASSERT_TRUE(SetupSync());
74 74
75 const int kNumApps = 5; 75 const int kNumApps = 5;
76 for (int i = 0; i < kNumApps; ++i) { 76 for (int i = 0; i < kNumApps; ++i) {
77 InstallPlatformApp(GetProfile(0), i); 77 InstallPlatformApp(GetProfile(0), i);
78 InstallPlatformApp(verifier(), i); 78 InstallPlatformApp(verifier(), i);
79 } 79 }
80 80
81 ASSERT_TRUE(GetClient(0)->AwaitFullSyncCompletion()); 81 ASSERT_TRUE(GetClient(0)->AwaitCommitActivityCompletion());
82 82
83 ASSERT_TRUE(AllProfilesHaveSameAppsAsVerifier()); 83 ASSERT_TRUE(AllProfilesHaveSameAppsAsVerifier());
84 } 84 }
85 85
86 IN_PROC_BROWSER_TEST_F(SingleClientAppsSyncTest, InstallSomeApps) { 86 IN_PROC_BROWSER_TEST_F(SingleClientAppsSyncTest, InstallSomeApps) {
87 ASSERT_TRUE(SetupSync()); 87 ASSERT_TRUE(SetupSync());
88 88
89 int i = 0; 89 int i = 0;
90 90
91 const int kNumApps = 5; 91 const int kNumApps = 5;
92 for (int j = 0; j < kNumApps; ++i, ++j) { 92 for (int j = 0; j < kNumApps; ++i, ++j) {
93 InstallApp(GetProfile(0), i); 93 InstallApp(GetProfile(0), i);
94 InstallApp(verifier(), i); 94 InstallApp(verifier(), i);
95 } 95 }
96 96
97 const int kNumPlatformApps = 5; 97 const int kNumPlatformApps = 5;
98 for (int j = 0; j < kNumPlatformApps; ++i, ++j) { 98 for (int j = 0; j < kNumPlatformApps; ++i, ++j) {
99 InstallPlatformApp(GetProfile(0), i); 99 InstallPlatformApp(GetProfile(0), i);
100 InstallPlatformApp(verifier(), i); 100 InstallPlatformApp(verifier(), i);
101 } 101 }
102 102
103 ASSERT_TRUE(GetClient(0)->AwaitFullSyncCompletion()); 103 ASSERT_TRUE(GetClient(0)->AwaitCommitActivityCompletion());
104 104
105 ASSERT_TRUE(AllProfilesHaveSameAppsAsVerifier()); 105 ASSERT_TRUE(AllProfilesHaveSameAppsAsVerifier());
106 } 106 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698