Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Side by Side Diff: chrome/browser/sync/test/integration/cross_platform_sync_test.cc

Issue 148723002: [sync] Eliminate Await*SyncCompletion methods in integration tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address feedback Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/sync/test/integration/migration_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/profiles/profile.h" 5 #include "chrome/browser/profiles/profile.h"
6 #include "chrome/browser/sync/test/integration/bookmarks_helper.h" 6 #include "chrome/browser/sync/test/integration/bookmarks_helper.h"
7 #include "chrome/browser/sync/test/integration/profile_sync_service_harness.h" 7 #include "chrome/browser/sync/test/integration/profile_sync_service_harness.h"
8 #include "chrome/browser/sync/test/integration/sync_test.h" 8 #include "chrome/browser/sync/test/integration/sync_test.h"
9 9
10 using bookmarks_helper::AddURL; 10 using bookmarks_helper::AddURL;
11 using bookmarks_helper::ModelMatchesVerifier; 11 using bookmarks_helper::ModelMatchesVerifier;
12 12
13 // These tests are run on the Chrome on iOS buildbots as part of cross-platform 13 // These tests are run on the Chrome on iOS buildbots as part of cross-platform
14 // sync integration tests, and are not meant to be run on the chromium 14 // sync integration tests, and are not meant to be run on the chromium
15 // buildbots. As a result, all tests below must have a DISABLED_ annotation, 15 // buildbots. As a result, all tests below must have a DISABLED_ annotation,
16 // which will be overridden when they are run on the Chrome on iOS buildbots. 16 // which will be overridden when they are run on the Chrome on iOS buildbots.
17 class CrossPlatformSyncTest : public SyncTest { 17 class CrossPlatformSyncTest : public SyncTest {
18 public: 18 public:
19 CrossPlatformSyncTest() : SyncTest(SINGLE_CLIENT) {} 19 CrossPlatformSyncTest() : SyncTest(SINGLE_CLIENT) {}
20 virtual ~CrossPlatformSyncTest() {} 20 virtual ~CrossPlatformSyncTest() {}
21 21
22 private: 22 private:
23 DISALLOW_COPY_AND_ASSIGN(CrossPlatformSyncTest); 23 DISALLOW_COPY_AND_ASSIGN(CrossPlatformSyncTest);
24 }; 24 };
25 25
26 IN_PROC_BROWSER_TEST_F(CrossPlatformSyncTest, DISABLED_AddBookmark) { 26 IN_PROC_BROWSER_TEST_F(CrossPlatformSyncTest, DISABLED_AddBookmark) {
27 ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; 27 ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
28 ASSERT_TRUE(AddURL(0, L"Google", GURL("http://www.google.co.uk"))); 28 ASSERT_TRUE(AddURL(0, L"Google", GURL("http://www.google.co.uk")));
29 ASSERT_TRUE(GetClient(0)->AwaitFullSyncCompletion()); 29 ASSERT_TRUE(GetClient(0)->AwaitCommitActivityCompletion());
30 ASSERT_TRUE(ModelMatchesVerifier(0)); 30 ASSERT_TRUE(ModelMatchesVerifier(0));
31 } 31 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/sync/test/integration/migration_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698