Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 1487223002: Change PacketKey to be unique for each frame packet by including (Closed)

Created:
5 years ago by xjz
Modified:
5 years ago
Reviewers:
miu
CC:
chromium-reviews, cbentzel+watch_chromium.org, imcheng+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, feature-media-reviews_chromium.org, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change PacketKey to be unique for each frame packet by including frame_ID. PacketKey was originally generated by combining capture_time, ssrc, and packet_id. This key may not necessarily be unique. Two or more frames with the same cpature_time had the same key and may cause one to be evicted from the list. This, in turn, will cause a receiver to become blocked waiting on a frame that the PacedSender will never attempt to send. BUG=373560 Committed: https://crrev.com/12ede5b629ef29311dd65f8f1c6c6ae4064c3b4d Cr-Commit-Position: refs/heads/master@{#363035}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -31 lines) Patch
M media/cast/net/pacing/paced_sender.h View 3 chunks +19 lines, -6 lines 0 comments Download
M media/cast/net/pacing/paced_sender.cc View 5 chunks +10 lines, -8 lines 0 comments Download
M media/cast/net/pacing/paced_sender_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M media/cast/net/rtp/packet_storage_unittest.cc View 1 2 chunks +4 lines, -5 lines 0 comments Download
M media/cast/net/rtp/rtp_packetizer.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M media/cast/net/rtp/rtp_sender.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
xjz
5 years ago (2015-12-02 19:26:29 UTC) #4
miu
lgtm % one nit: https://codereview.chromium.org/1487223002/diff/40001/media/cast/net/rtp/packet_storage_unittest.cc File media/cast/net/rtp/packet_storage_unittest.cc (right): https://codereview.chromium.org/1487223002/diff/40001/media/cast/net/rtp/packet_storage_unittest.cc#newcode27 media/cast/net/rtp/packet_storage_unittest.cc:27: const base::TimeTicks kTicks; Looks like ...
5 years ago (2015-12-03 02:42:12 UTC) #5
xjz
https://codereview.chromium.org/1487223002/diff/40001/media/cast/net/rtp/packet_storage_unittest.cc File media/cast/net/rtp/packet_storage_unittest.cc (right): https://codereview.chromium.org/1487223002/diff/40001/media/cast/net/rtp/packet_storage_unittest.cc#newcode27 media/cast/net/rtp/packet_storage_unittest.cc:27: const base::TimeTicks kTicks; On 2015/12/03 02:42:12, miu wrote: > ...
5 years ago (2015-12-03 19:15:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1487223002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1487223002/60001
5 years ago (2015-12-03 19:17:52 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years ago (2015-12-03 19:50:06 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-03 19:50:59 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/12ede5b629ef29311dd65f8f1c6c6ae4064c3b4d
Cr-Commit-Position: refs/heads/master@{#363035}

Powered by Google App Engine
This is Rietveld 408576698