Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 1487213004: Make PathData's LazyInstance Leaky (Closed)

Created:
5 years ago by scottmg
Modified:
5 years ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make PathData's LazyInstance Leaky Running the destructors doesn't offer any benefit, and makes PathService require an AtExitManager. So instead, make it leaky. This makes PathService usable earlier in the startup flow. Separated out of https://codereview.chromium.org/1481703002/. R=cpu@chromium.org TBR=cpu@chromium.org BUG=546288, 561653, 564328 Committed: https://chromium.googlesource.com/chromium/src/+/4189fab5291cf30b85eff6690b7e1c13f797b872

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M base/path_service.cc View 1 chunk +1 line, -11 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1487213004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1487213004/1
5 years ago (2015-12-03 20:54:02 UTC) #3
cpu_(ooo_6.6-7.5)
lgtm
5 years ago (2015-12-03 20:54:08 UTC) #4
scottmg
buildbot is experiencing some flakiness, so doesn't know that all the tryjobs are green+done. landing ...
5 years ago (2015-12-03 23:10:57 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4189fab5291cf30b85eff6690b7e1c13f797b872 Cr-Commit-Position: refs/heads/master@{#363078}
5 years ago (2015-12-03 23:15:43 UTC) #7
scottmg
5 years ago (2015-12-03 23:16:18 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4189fab5291cf30b85eff6690b7e1c13f797b872 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698