Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Issue 14872005: Remove use_system_v8 logic from the mailine gyp file. (Closed)

Created:
7 years, 7 months ago by Paweł Hajdan Jr.
Modified:
7 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Remove use_system_v8 logic from the mailine gyp file. It now lives in build/linux/unbundle in Chromium source tree. BUG=chromium:226860 Moved to https://codereview.chromium.org/15001031/.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+828 lines, -906 lines) Patch
M tools/gyp/v8.gyp View 1 chunk +828 lines, -906 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Paweł Hajdan Jr.
Please see the bug for reference. I hope you'll like less complexity in the gyp ...
7 years, 7 months ago (2013-05-02 22:35:09 UTC) #1
Paweł Hajdan Jr.
ping
7 years, 7 months ago (2013-05-06 19:11:24 UTC) #2
Jakob Kummerow
LGTM -- I guess. The Rietveld diff viewer turns this change into such a big ...
7 years, 7 months ago (2013-05-07 12:12:22 UTC) #3
Jakob Kummerow
7 years, 7 months ago (2013-05-15 13:11:18 UTC) #4
Sorry, sat on this for way too long, and now the patch doesn't apply any more,
so I've re-created, re-uploaded and committed it at
https://codereview.chromium.org/15001031/.

Thanks for the contribution, I do indeed like the simplification!

Powered by Google App Engine
This is Rietveld 408576698