Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1670)

Unified Diff: runtime/vm/flow_graph_optimizer.h

Issue 14872002: Improve load forwarding: (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: address Srdjan's comments Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_inliner.cc ('k') | runtime/vm/flow_graph_optimizer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_optimizer.h
diff --git a/runtime/vm/flow_graph_optimizer.h b/runtime/vm/flow_graph_optimizer.h
index 8a616a344dc441ed3d032b71b1d5b50f6850fa25..5b2bfa6619408f2245e1415e2b8cd2efe4419712 100644
--- a/runtime/vm/flow_graph_optimizer.h
+++ b/runtime/vm/flow_graph_optimizer.h
@@ -17,7 +17,7 @@ class ParsedFunction;
class FlowGraphOptimizer : public FlowGraphVisitor {
public:
FlowGraphOptimizer(FlowGraph* flow_graph,
- GrowableArray<Field*>* guarded_fields)
+ GrowableArray<const Field*>* guarded_fields)
: FlowGraphVisitor(flow_graph->reverse_postorder()),
flow_graph_(flow_graph),
guarded_fields_(guarded_fields) { }
@@ -35,7 +35,8 @@ class FlowGraphOptimizer : public FlowGraphVisitor {
// shift can be a truncating Smi shift-left and result is always Smi.
void TryOptimizeLeftShiftWithBitAndPattern();
- void Canonicalize();
+ // Returns true if any instructions were canonicalized away.
+ bool Canonicalize();
void EliminateDeadPhis();
@@ -170,10 +171,10 @@ class FlowGraphOptimizer : public FlowGraphVisitor {
Definition* left_instr,
Definition* right_instr);
- void AddToGuardedFields(Field* field);
+ void AddToGuardedFields(const Field& field);
FlowGraph* flow_graph_;
- GrowableArray<Field*>* guarded_fields_;
+ GrowableArray<const Field*>* guarded_fields_;
DISALLOW_COPY_AND_ASSIGN(FlowGraphOptimizer);
};
« no previous file with comments | « runtime/vm/flow_graph_inliner.cc ('k') | runtime/vm/flow_graph_optimizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698