Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h

Issue 1487083003: It's not just the last column set that may need additional fragmentainer groups. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 LayoutUnit nextLogicalTopForUnbreakableContent(LayoutUnit flowThreadOffset, LayoutUnit contentLogicalHeight) const; 89 LayoutUnit nextLogicalTopForUnbreakableContent(LayoutUnit flowThreadOffset, LayoutUnit contentLogicalHeight) const;
90 90
91 LayoutFlowThread* flowThread() const { return m_flowThread; } 91 LayoutFlowThread* flowThread() const { return m_flowThread; }
92 92
93 LayoutBlockFlow* multiColumnBlockFlow() const { return toLayoutBlockFlow(par ent()); } 93 LayoutBlockFlow* multiColumnBlockFlow() const { return toLayoutBlockFlow(par ent()); }
94 LayoutMultiColumnFlowThread* multiColumnFlowThread() const { return toLayout MultiColumnFlowThread(flowThread()); } 94 LayoutMultiColumnFlowThread* multiColumnFlowThread() const { return toLayout MultiColumnFlowThread(flowThread()); }
95 95
96 LayoutMultiColumnSet* nextSiblingMultiColumnSet() const; 96 LayoutMultiColumnSet* nextSiblingMultiColumnSet() const;
97 LayoutMultiColumnSet* previousSiblingMultiColumnSet() const; 97 LayoutMultiColumnSet* previousSiblingMultiColumnSet() const;
98 98
99 // Return true if we have a fragmentainer group that can hold a column at th e specified flow thread block offset.
100 bool hasFragmentainerGroupForColumnAt(LayoutUnit offsetInFlowThread) const;
101
99 MultiColumnFragmentainerGroup& appendNewFragmentainerGroup(); 102 MultiColumnFragmentainerGroup& appendNewFragmentainerGroup();
100 103
101 LayoutUnit logicalTopInFlowThread() const; 104 LayoutUnit logicalTopInFlowThread() const;
102 LayoutUnit logicalBottomInFlowThread() const; 105 LayoutUnit logicalBottomInFlowThread() const;
103 LayoutUnit logicalHeightInFlowThread() const { return logicalBottomInFlowThr ead() - logicalTopInFlowThread(); } 106 LayoutUnit logicalHeightInFlowThread() const { return logicalBottomInFlowThr ead() - logicalTopInFlowThread(); }
104 LayoutRect flowThreadPortionRect() const; 107 LayoutRect flowThreadPortionRect() const;
105 LayoutRect flowThreadPortionOverflowRect() const; 108 LayoutRect flowThreadPortionOverflowRect() const;
106 LayoutRect overflowRectForFlowThreadPortion(const LayoutRect& flowThreadPort ionRect, bool isFirstPortion, bool isLastPortion) const; 109 LayoutRect overflowRectForFlowThreadPortion(const LayoutRect& flowThreadPort ionRect, bool isFirstPortion, bool isLastPortion) const;
107 110
108 // The used CSS value of column-count, i.e. how many columns there are room for without overflowing. 111 // The used CSS value of column-count, i.e. how many columns there are room for without overflowing.
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 193
191 bool m_initialHeightCalculated; 194 bool m_initialHeightCalculated;
192 }; 195 };
193 196
194 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutMultiColumnSet, isLayoutMultiColumnSet()); 197 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutMultiColumnSet, isLayoutMultiColumnSet());
195 198
196 } // namespace blink 199 } // namespace blink
197 200
198 #endif // LayoutMultiColumnSet_h 201 #endif // LayoutMultiColumnSet_h
199 202
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698