Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 148703004: Have TreeScopeStyleSheetCollection::document() return a reference. (Closed)

Created:
6 years, 10 months ago by deepak.sa
Modified:
6 years, 10 months ago
CC:
blink-reviews, dglazkov+blink, sof, eae+blinkwatch, adamk+blink_chromium.org, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Have TreeScopeStyleSheetCollection::document() return a reference. Have TresScopeStyleSheetCollection::document() return a reference instead of pointer as TreeScope::document() cannot return NULL. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166297

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : StyleSheetCollection changed to TreeScopeStyleSheetCollection #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M Source/core/dom/DocumentStyleSheetCollection.cpp View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/TreeScopeStyleSheetCollection.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/dom/TreeScopeStyleSheetCollection.cpp View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
deepak.sa
Please have a look.
6 years, 10 months ago (2014-01-30 10:54:57 UTC) #1
Inactive
lgtm
6 years, 10 months ago (2014-01-30 14:33:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/148703004/20001
6 years, 10 months ago (2014-01-30 14:33:43 UTC) #3
commit-bot: I haz the power
Failed to apply patch for Source/core/dom/StyleSheetCollection.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 10 months ago (2014-01-30 14:33:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/148703004/60001
6 years, 10 months ago (2014-01-31 09:46:49 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-01-31 12:42:12 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=24962
6 years, 10 months ago (2014-01-31 12:42:12 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 12:42:18 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 12:42:22 UTC) #9
deepak.sa
The CQ bit was checked by deepak.sa@samsung.com
6 years, 10 months ago (2014-02-03 07:40:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/148703004/60001
6 years, 10 months ago (2014-02-03 07:40:54 UTC) #11
commit-bot: I haz the power
Change committed as 166297
6 years, 10 months ago (2014-02-03 09:03:44 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 09:03:45 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 09:03:47 UTC) #14
commit-bot: I haz the power
6 years, 10 months ago (2014-02-03 09:03:54 UTC) #15
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698