Support numbers in settings-checkbox

chrome/browser/resources/settings/controls/settings_checkbox.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * `settings-checkbox` is a checkbox that controls a supplied preference.
  *
  * Example:
  *      <settings-checkbox pref="{{prefs.settings.enableFoo}}"
@@ skipping 69 matching lines @@
    */
   prefValueChanged_: function(prefValue) {
     this.checked = this.getNewValue_(prefValue);
   },
 
   /**
    * Polymer observer for checked.
    * @private
    */
   checkedChanged_: function() {
-    this.set('pref.value', this.getNewValue_(this.checked));
+    if (!this.pref)
+      return;
+    /** @type {boolean} */ var newValue = this.getNewValue_(this.checked);
+    // Ensure that newValue is the correct type for the pref type, either
+    // a bolean or a number.

[Dan Beam, 2015/12/02 05:11:59]

boolean

[stevenjb, 2015/12/02 18:14:51]

Done.

+    if (this.pref.type == chrome.settingsPrivate.PrefType.NUMBER) {
+      this.set('pref.value', newValue ? 1 : 0);
+      return;
+    }
+    this.set('pref.value', newValue);
   },
 
   /**
    * @param {*} value
    * @return {boolean} The value as a boolean, inverted if |inverted| is true.
    * @private
    */
   getNewValue_: function(value) {
     return this.inverted ? !value : !!value;
   },
 
   /**
    * @param {boolean} disabled
    * @param {!chrome.settingsPrivate.PrefObject} pref
    * @return {boolean} Whether the checkbox should be disabled.
    * @private
    */
   checkboxDisabled_: function(disabled, pref) {
     return disabled || this.isPrefPolicyControlled(pref);
   },
 });