Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 148693003: Remove legacy HTMLAllCollection.tags() method (Closed)

Created:
6 years, 10 months ago by Inactive
Modified:
6 years, 10 months ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, devtools-reviews_chromium.org, arv+blink, aandrey+blink_chromium.org, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Remove legacy HTMLAllCollection.tags() method Remove legacy HTMLAllCollection.tags() method. Our DocumentAllTags UseCounter reports that it is used only by 0.001% of pages. It should thus be safe to remove. R=arv, jochen BUG=290891 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166870

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -36 lines) Patch
M LayoutTests/fast/dom/HTMLDocument/document-all-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/HTMLDocument/script-tests/document-all.js View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/fast/dom/document-all-tags.html View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/fast/dom/document-all-tags-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M LayoutTests/inspector/console/console-format-collections-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLAllCollection.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLAllCollection.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/HTMLAllCollection.idl View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Inactive
I have just sent an intent to deprecate and remove to blink-dev.
6 years, 10 months ago (2014-02-10 02:42:33 UTC) #1
arv (Not doing code reviews)
LGTM
6 years, 10 months ago (2014-02-10 02:44:32 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 10 months ago (2014-02-10 12:26:52 UTC) #3
Inactive
This received 3 API OWNER LGTMs on blink-dev, landing!
6 years, 10 months ago (2014-02-10 21:29:54 UTC) #4
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-10 21:30:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/148693003/1
6 years, 10 months ago (2014-02-10 21:30:24 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-10 23:09:28 UTC) #7
Message was sent while issue was closed. 
Change committed as 166870

Powered by Google App Engine
This is Rietveld 408576698