Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 1486923005: Fix tests (Closed)

Created:
5 years ago by hausner
Modified:
5 years ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Bill Hesse
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Removing an assert that trips after the TL class removal. I will look into why the assertion fails in a follow-on change. Committed: https://github.com/dart-lang/sdk/commit/1df143b6b6943b501d00564d3510f47108b82c62

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M runtime/vm/object.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
hausner
5 years ago (2015-12-01 20:59:25 UTC) #3
hausner
Committed patchset #1 (id:1) manually as 1df143b6b6943b501d00564d3510f47108b82c62 (presubmit successful).
5 years ago (2015-12-01 21:04:43 UTC) #5
hausner
TBR=rmacnak
5 years ago (2015-12-01 21:05:02 UTC) #6
rmacnak
5 years ago (2015-12-01 21:09:31 UTC) #7
Message was sent while issue was closed.
lgtm


Given the in-flight changes to where top-level members are found, I think this
assert is no longer valid anyway.

Powered by Google App Engine
This is Rietveld 408576698