Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1486923004: Retract GrRenderTarget a bit (Closed)

Created:
5 years ago by robertphillips
Modified:
5 years ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Retract GrRenderTarget a bit These sites don't necessarily need the full power of a GrRenderTarget object. This is a clean up for switching over to GrRenderTargetProxys. Committed: https://skia.googlesource.com/skia/+/7bceedc550513b13e0065aca66e55204a2ba3e1f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -48 lines) Patch
M include/gpu/GrClip.h View 2 chunks +0 lines, -8 lines 0 comments Download
M include/gpu/GrDrawContext.h View 2 chunks +5 lines, -0 lines 0 comments Download
M src/gpu/GrAtlasTextContext.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 7 chunks +9 lines, -9 lines 0 comments Download
M src/gpu/GrBlurUtils.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/gpu/GrBlurUtils.cpp View 6 chunks +4 lines, -7 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrSoftwarePathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTextContext.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrTextContext.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/SkGpuDevice_drawTexture.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrAAHairLinePathRenderer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/batches/GrTessellatingPathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ClipBoundsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
robertphillips
5 years ago (2015-12-01 20:19:53 UTC) #3
bsalomon
lgtm
5 years ago (2015-12-01 20:32:50 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1486923004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1486923004/1
5 years ago (2015-12-01 20:35:45 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-01 20:50:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1486923004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1486923004/1
5 years ago (2015-12-01 20:50:33 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-01 20:51:30 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7bceedc550513b13e0065aca66e55204a2ba3e1f

Powered by Google App Engine
This is Rietveld 408576698