Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1486923002: EDK: Add mojo::util::StringPrintf() (etc.) and convert away from base's. (Closed)

Created:
5 years ago by viettrungluu
Modified:
5 years ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

EDK: Add mojo::util::StringPrintf() (etc.) and convert away from base's. This is loosely based on Chromium's base::StringPrintf() (but simplified/improved). Note that the names of "append f", etc. are also made more consistent (ditto for "v printf", etc.). R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/2f3026eb9b46ffe09499a049cc1d8c9ba725c03c

Patch Set 1 #

Total comments: 2

Patch Set 2 : there is no try #

Unified diffs Side-by-side diffs Delta from patch set Stats (+285 lines, -25 lines) Patch
M mojo/edk/system/channel.cc View 6 chunks +24 lines, -21 lines 0 comments Download
M mojo/edk/system/message_pipe_perftest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M mojo/edk/util/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
A mojo/edk/util/string_printf.h View 1 chunk +38 lines, -0 lines 0 comments Download
A mojo/edk/util/string_printf.cc View 1 1 chunk +92 lines, -0 lines 0 comments Download
A mojo/edk/util/string_printf_unittest.cc View 1 chunk +124 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
viettrungluu
5 years ago (2015-12-01 03:25:43 UTC) #1
vardhan
lgtm https://codereview.chromium.org/1486923002/diff/1/mojo/edk/util/string_printf.cc File mojo/edk/util/string_printf.cc (right): https://codereview.chromium.org/1486923002/diff/1/mojo/edk/util/string_printf.cc#newcode20 mojo/edk/util/string_printf.cc:20: // Size of the small stack buffer to ...
5 years ago (2015-12-01 19:09:26 UTC) #2
viettrungluu
thanks https://codereview.chromium.org/1486923002/diff/1/mojo/edk/util/string_printf.cc File mojo/edk/util/string_printf.cc (right): https://codereview.chromium.org/1486923002/diff/1/mojo/edk/util/string_printf.cc#newcode20 mojo/edk/util/string_printf.cc:20: // Size of the small stack buffer to ...
5 years ago (2015-12-01 22:24:55 UTC) #3
viettrungluu
5 years ago (2015-12-01 22:25:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2f3026eb9b46ffe09499a049cc1d8c9ba725c03c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698