Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1486913002: X87: [runtime] Use "the hole" instead of smi 0 as sentinel for context extension. (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [runtime] Use "the hole" instead of smi 0 as sentinel for context extension. port 9e6448813d41858c3f879ecde41b13bda0770673 (r32407) original commit message: This way we avoid the %_IsSmi magic that is required in TurboFan to (efficiently) check abitrary context slots for smi 0. Checking against "the hole" is common in the AstGraphBuilder and "the hole" is also used to mark other context slots as not initialized. BUG= Committed: https://crrev.com/a8b2d9a18f2bf98cf9beca0ed85cb864d13f0700 Cr-Commit-Position: refs/heads/master@{#32441}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -14 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 3 chunks +12 lines, -14 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
5 years ago (2015-12-01 02:38:25 UTC) #2
Weiliang
lgtm
5 years ago (2015-12-01 06:19:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1486913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1486913002/1
5 years ago (2015-12-01 06:19:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 06:39:03 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-01 06:39:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a8b2d9a18f2bf98cf9beca0ed85cb864d13f0700
Cr-Commit-Position: refs/heads/master@{#32441}

Powered by Google App Engine
This is Rietveld 408576698