Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: ppapi/shared_impl/resource.h

Issue 14869007: Merge 197686 "Remove Pepper URLLoader from resource tracker early." (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1453/src/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ppapi/shared_impl/resource.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/shared_impl/resource.h
===================================================================
--- ppapi/shared_impl/resource.h (revision 198489)
+++ ppapi/shared_impl/resource.h (working copy)
@@ -206,6 +206,14 @@
// Logs a message to the console from this resource.
void Log(PP_LogLevel level, const std::string& message);
+ // Removes the resource from the ResourceTracker's tables. This normally
+ // happens as part of Resource destruction, but if a subclass destructor
+ // has a risk of re-entering destruction via the ResourceTracker, it can
+ // call this explicitly to get rid of the table entry before continuing
+ // with the destruction. If the resource is not in the ResourceTracker's
+ // tables, silently does nothing. See http://crbug.com/159429.
+ void RemoveFromResourceTracker();
+
// Notifications for subclasses.
virtual void LastPluginRefWasDeleted() {}
virtual void InstanceWasDeleted() {}
« no previous file with comments | « no previous file | ppapi/shared_impl/resource.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698